⚡ perf: Avoid redundant list allocations in MobileBy FindElements

src/Appium.Net/Appium/MobileBy.cs

@@ -57,7 +57,7 @@ public override IWebElement FindElement(ISearchContext context)
         public override ReadOnlyCollection<IWebElement> FindElements(ISearchContext context)
         {
             if (context is IFindsByFluentSelector<IWebElement> finder)
-                return finder.FindElements(_searchingCriteriaName, selector).ToList().AsReadOnly();
+                return finder.FindElements(_searchingCriteriaName, selector).AsReadOnly();
             throw new InvalidCastException($"Unable to cast {context.GetType().FullName} " +
                                            $"to {nameof(IFindsByFluentSelector<IWebElement>)}");
         }
@@ -157,7 +157,7 @@ public override IWebElement FindElement(ISearchContext context)
         public override ReadOnlyCollection<IWebElement> FindElements(ISearchContext context)
         {
             if (context is IFindByAccessibilityId<IWebElement> finder)
-                return finder.FindElementsByAccessibilityId(selector).ToList().AsReadOnly();
+                return finder.FindElementsByAccessibilityId(selector).AsReadOnly();
             return base.FindElements(context);
         }
 
@@ -198,7 +198,7 @@ public override IWebElement FindElement(ISearchContext context)
         public override ReadOnlyCollection<IWebElement> FindElements(ISearchContext context)
         {
             if (context is IFindByAndroidUIAutomator<IWebElement> finder)
-                return finder.FindElementsByAndroidUIAutomator(selector).ToList().AsReadOnly();
+                return finder.FindElementsByAndroidUIAutomator(selector).AsReadOnly();
             return base.FindElements(context);
         }
 
@@ -230,7 +230,7 @@ public override IWebElement FindElement(ISearchContext context)
         public override ReadOnlyCollection<IWebElement> FindElements(ISearchContext context)
         {
             if (context is IFindByAndroidDataMatcher<IWebElement> finder)
-                return finder.FindElementsByAndroidDataMatcher(selector).ToList().AsReadOnly();
+                return finder.FindElementsByAndroidDataMatcher(selector).AsReadOnly();
             return base.FindElements(context);
         }
 
@@ -262,7 +262,7 @@ public override IWebElement FindElement(ISearchContext context)
         public override ReadOnlyCollection<IWebElement> FindElements(ISearchContext context)
         {
             if (context is IFindByAndroidViewMatcher<IWebElement> finder)
-                return finder.FindElementsByAndroidViewMatcher(selector).ToList().AsReadOnly();
+                return finder.FindElementsByAndroidViewMatcher(selector).AsReadOnly();
             return base.FindElements(context);
         }
 
@@ -290,7 +290,7 @@ public override IWebElement FindElement(ISearchContext context)
         public override ReadOnlyCollection<IWebElement> FindElements(ISearchContext context)
         {
             if (context is IFindByWindowsUIAutomation<IWebElement> finder)
-                return finder.FindElementsByWindowsUIAutomation(selector).ToList().AsReadOnly();
+                return finder.FindElementsByWindowsUIAutomation(selector).AsReadOnly();
             return base.FindElements(context);
         }
 
@@ -318,7 +318,7 @@ public override IWebElement FindElement(ISearchContext context)
         public override ReadOnlyCollection<IWebElement> FindElements(ISearchContext context)
         {
             if (context is IFindByTizenUIAutomation<IWebElement> finder)
-                return finder.FindElementsByTizenUIAutomation(selector).ToList().AsReadOnly();
+                return finder.FindElementsByTizenUIAutomation(selector).AsReadOnly();
             return base.FindElements(context);
         }
 
@@ -346,7 +346,7 @@ public override IWebElement FindElement(ISearchContext context)
         public override ReadOnlyCollection<IWebElement> FindElements(ISearchContext context)
         {
             if (context is IFindsByIosNSPredicate<IWebElement> finder)
-                return finder.FindElementsByIosNsPredicate(selector).ToList().AsReadOnly();
+                return finder.FindElementsByIosNsPredicate(selector).AsReadOnly();
             return base.FindElements(context);
         }
 
@@ -374,7 +374,7 @@ public override IWebElement FindElement(ISearchContext context)
         public override ReadOnlyCollection<IWebElement> FindElements(ISearchContext context)
         {
             if (context is IFindsByIosClassChain<IWebElement> finder)
-                return finder.FindElementsByIosClassChain(selector).ToList().AsReadOnly();
+                return finder.FindElementsByIosClassChain(selector).AsReadOnly();
             return base.FindElements(context);
         }
 
@@ -402,7 +402,7 @@ public override IWebElement FindElement(ISearchContext context)
         public override ReadOnlyCollection<IWebElement> FindElements(ISearchContext context)
         {
             if (context is IFindsByImage<IWebElement> finder)
-                return finder.FindElementsByImage(selector).ToList().AsReadOnly();
+                return finder.FindElementsByImage(selector).AsReadOnly();
             return base.FindElements(context);
         }
 

src/Appium.Net/Appium/ReadOnlyCollectionExtensions.cs

@@ -0,0 +1,19 @@
+using System;
+using System.Collections.Generic;
+using System.Collections.ObjectModel;
+using System.Linq;
+
+namespace OpenQA.Selenium.Appium
+{
+    internal static class ReadOnlyCollectionExtensions
+    {
+        public static ReadOnlyCollection<T> AsReadOnly<T>(this IReadOnlyCollection<T> collection)
+        {
+            if (collection is ReadOnlyCollection<T> readOnlyCollection)
+            {
+                return readOnlyCollection;
+            }
+            return new ReadOnlyCollection<T>(collection as IList<T> ?? collection.ToList());
+        }
+    }
+}