feat(tap): Add @eN snapshot refs for capture-driven taps#12
Draft
DouweBos wants to merge 1 commit into
Draft
Conversation
`capture-ui` now assigns each element a `@eN` ref and persists its coordinates per session, so `tap-on @e3` taps the cached point directly. Stale snapshots warn but still act, since refs are explicitly ephemeral. Also extracts a pure `selectDebuggerUrl` from `resolveDebuggerUrl` and types the `recordingPath` field on `Session` directly instead of casting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
capture-uinow assigns each accessible element a short ephemeral ref (@e1,@e2, …) and persists its resolved coordinates per session under~/.conductor/snapshots/<session>.json.tap-on @e3resolves through that store and taps the cached point directly — skipping fuzzy text/id matching and a full hierarchy re-query.Refs are deliberately ephemeral. A snapshot captured >60s ago, or on a different device, emits an advisory warning but the tap still fires; the agent is expected to re-run
capture-uiif a tap misses. Explicit--text/--idstill win over a bare@eN.Other small changes folded in:
metro-cdp: splitresolveDebuggerUrlinto a pureselectDebuggerUrl+ async target/displayName fetch, so the selection logic is unit-testable.flow-recorder/session:recordingPathis now a real optional field onSessioninstead of cast-throughSessionWithRecording.snapshot-ref,metro-cdp,flow-recorder.