Skip to content

Conversation

@DrBarnabus
Copy link
Owner

@DrBarnabus DrBarnabus commented Sep 1, 2025

  • Bump JetBrains.Annotations to v2025.2.1
  • Bump xunit.runner.visualstudio to v3.1.4

Summary by CodeRabbit

  • New Features
    • No user-facing changes.
  • Tests
    • Upgraded test runner to version 3.1.4 for improved reliability across .NET 8 and .NET 9.
  • Chores
    • Updated JetBrains.Annotations to version 2025.2.1.
    • Aligned central package versions to ensure consistency across projects.
    • General dependency maintenance with no impact on application behaviour.

- Bump `JetBrains.Annotations` to v2025.2.1
- Bump `xunit.runner.visualstudio` to v3.1.4
@coderabbitai
Copy link

coderabbitai bot commented Sep 1, 2025

Walkthrough

Central package versions for JetBrains.Annotations and xunit.runner.visualstudio were incremented, and corresponding packages.lock.json files across multiple projects/target frameworks were updated to reflect the new requested/resolved versions and content hashes. No source code or public API declarations were changed.

Changes

Cohort / File(s) Summary
Central package versions
src/Directory.Packages.props
Bumped JetBrains.Annotations 2025.2.0 → 2025.2.1 and xunit.runner.visualstudio 3.1.3 → 3.1.4.
JetBrains.Annotations lockfile updates
src/CompositeKey.Analyzers/packages.lock.json, src/CompositeKey.Analyzers.Common/packages.lock.json, src/CompositeKey.SourceGeneration/packages.lock.json
Updated JetBrains.Annotations entries to requested “[2025.2.1, )”, resolved “2025.2.1”, with new contentHash for affected target frameworks (.NETStandard2.0, net8.0 where applicable).
xunit.runner.visualstudio lockfile updates (tests)
src/CompositeKey.Analyzers.UnitTests/packages.lock.json, src/CompositeKey.Analyzers.Common.UnitTests/packages.lock.json, src/CompositeKey.SourceGeneration.UnitTests/packages.lock.json, src/CompositeKey.SourceGeneration.FunctionalTests/packages.lock.json
Updated xunit.runner.visualstudio entries in net8.0/net9.0 blocks to requested “[3.1.4, )”, resolved “3.1.4”, with new contentHash.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • ci: Add codecov test results #24 — Also updates PackageVersion for xunit.runner.visualstudio in src/Directory.Packages.props, indicating related dependency management changes.

Poem

I twitch my ears at version chimes,
Hop-hop through lockfiles’ tidy lines.
Annotations fresh, the runner spry—
New hashes gleam, the builds comply.
With gentle paws I stamp “All set!”
A carrot toast to every set! 🥕


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3f5a44c and 411bd08.

📒 Files selected for processing (8)
  • src/CompositeKey.Analyzers.Common.UnitTests/packages.lock.json (2 hunks)
  • src/CompositeKey.Analyzers.Common/packages.lock.json (1 hunks)
  • src/CompositeKey.Analyzers.UnitTests/packages.lock.json (2 hunks)
  • src/CompositeKey.Analyzers/packages.lock.json (2 hunks)
  • src/CompositeKey.SourceGeneration.FunctionalTests/packages.lock.json (2 hunks)
  • src/CompositeKey.SourceGeneration.UnitTests/packages.lock.json (2 hunks)
  • src/CompositeKey.SourceGeneration/packages.lock.json (2 hunks)
  • src/Directory.Packages.props (2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-28T19:57:32.504Z
Learnt from: DrBarnabus
PR: DrBarnabus/CompositeKey#30
File: src/CompositeKey.Analyzers.Common.UnitTests/Validation/TemplateValidationTests.cs:11-42
Timestamp: 2025-08-28T19:57:32.504Z
Learning: CompositeKey test projects use MSBuild's <Using Include="..." /> elements in .csproj files combined with <ImplicitUsings>enable</ImplicitUsings> in Directory.Build.props to automatically include Xunit and Shouldly namespaces, eliminating the need for explicit using statements in test files.

Applied to files:

  • src/Directory.Packages.props
📚 Learning: 2025-08-28T19:57:32.503Z
Learnt from: DrBarnabus
PR: DrBarnabus/CompositeKey#30
File: src/CompositeKey.Analyzers.Common.UnitTests/Validation/TemplateValidationTests.cs:11-42
Timestamp: 2025-08-28T19:57:32.503Z
Learning: In CompositeKey projects, test files use global usings (typically in GlobalUsings.cs files) for common imports like xUnit and Shouldly, so individual test files don't need explicit using directives for these frameworks.

Applied to files:

  • src/Directory.Packages.props
📚 Learning: 2025-08-28T19:57:32.503Z
Learnt from: DrBarnabus
PR: DrBarnabus/CompositeKey#30
File: src/CompositeKey.Analyzers.Common.UnitTests/Validation/TemplateValidationTests.cs:11-42
Timestamp: 2025-08-28T19:57:32.503Z
Learning: In CompositeKey projects, test files use global usings configuration (likely through ImplicitUsings or similar mechanisms) for common imports like xUnit and Shouldly, eliminating the need for explicit using directives in individual test files.

Applied to files:

  • src/Directory.Packages.props
🔇 Additional comments (13)
src/CompositeKey.SourceGeneration.UnitTests/packages.lock.json (3)

66-68: xunit.runner.visualstudio: bump to 3.1.4 (net8.0) looks good

Requested/resolved versions and contentHash are consistent.


386-388: xunit.runner.visualstudio: bump to 3.1.4 (net9.0) looks good

Values align with the central version and mirror the net8.0 block.


66-68: All central/lock versions aligned: Verified that Directory.Packages.props and every packages.lock.json consistently reference JetBrains.Annotations 2025.2.1 and xunit.runner.visualstudio 3.1.4.

src/CompositeKey.Analyzers.Common/packages.lock.json (1)

13-15: JetBrains.Annotations: bump to 2025.2.1 (netstandard2.0) looks good

Requested/resolved versions and contentHash updated correctly.

src/CompositeKey.Analyzers.Common.UnitTests/packages.lock.json (2)

66-68: xunit.runner.visualstudio: bump to 3.1.4 (net8.0) looks good

Lock entry matches central version; hash updated.


386-388: xunit.runner.visualstudio: bump to 3.1.4 (net9.0) looks good

Consistent with the net8.0 block; no other changes.

src/CompositeKey.SourceGeneration.FunctionalTests/packages.lock.json (2)

66-68: xunit.runner.visualstudio: bump to 3.1.4 (net8.0) looks good

Versions and contentHash align; safe test-only change.


1184-1186: xunit.runner.visualstudio: bump to 3.1.4 (net9.0) looks good

Mirror of net8.0 update; all good.

src/CompositeKey.Analyzers/packages.lock.json (2)

13-15: JetBrains.Annotations: bump to 2025.2.1 (.NETStandard v2.0) looks good

Central bump reflected in lock; hash updated.


241-243: JetBrains.Annotations: bump to 2025.2.1 (net8.0) looks good

Requested/resolved/contentHash updated as expected.

src/Directory.Packages.props (1)

9-9: No stale 2025.2.0 or 3.1.3 references remain. Run dotnet restore --locked-mode on your local machine to ensure the lockfiles are in sync.

src/CompositeKey.SourceGeneration/packages.lock.json (1)

13-16: Lockfile entries updated consistently.

Requested/resolved JetBrains.Annotations now 2025.2.1 with new contentHash for .NETStandard2.0 and net8.0. Matches central version. LGTM.

Also applies to: 241-244

src/CompositeKey.Analyzers.UnitTests/packages.lock.json (1)

76-79: VS test adapter bump looks good.

xunit.runner.visualstudio updated to 3.1.4 (net8.0/net9.0) with matching contentHash. Should remain compatible with Microsoft.NET.Test.Sdk 17.14.1; please run test discovery to confirm locally.

Also applies to: 872-875

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch build/bump-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.55%. Comparing base (3f5a44c) to head (411bd08).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files          34       34           
  Lines        1503     1503           
  Branches      246      246           
=======================================
  Hits         1376     1376           
  Misses         59       59           
  Partials       68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DrBarnabus DrBarnabus merged commit 3f16e0f into main Sep 1, 2025
4 checks passed
@DrBarnabus DrBarnabus deleted the build/bump-deps branch September 1, 2025 20:01
@coderabbitai coderabbitai bot mentioned this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants