Fix isEqual stack overflow on circular references#237
Merged
Conversation
Add seen Set to track visited objects during recursive comparison. Prevents RangeError when Table.tsx memo comparator encounters circular references in memoData (e.g. React elements, DOM refs, compiler cache). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add seen Set to track visited objects during recursive comparison. Prevents RangeError when Table.tsx memo comparator encounters circular references in memoData (e.g. React elements, DOM refs, compiler cache).
PR Template
You can delete this markup if it doesn't apply to this PR
How to choose a release version?
From semver
Given a version number MAJOR.MINOR.PATCH:
If this PR is not for a major version change / does not introduce breaking changes, you can discard this template.
You can remove any unapplicable section if it doesn't apply to your introduced changes.
Breaking changes 💥
Migration guide from [previous version] 📋
Enums
In this version, all deprecated enums from [previous version] have been removed. The following table shows the equivalent new field for all removed fields:
When upgrading to [new version], simply import and use the new enums instead of the old ones (the props of the components is still named the same).
Deprecated Enums
The following emums have been deprecated, and will be removed in the next major version.
Props
In this version, all deprecated props from [previous version] have been removed. The following table shows the equivalent new field for all removed fields:
The following props have been deprecated, and will be removed in the next major version.