受注管理:受注一覧の対応状況変更の変更できませんのメッセージの番号が画面上にない #6506 の修正#6507
Open
systemfriend-tsuji wants to merge 1 commit intoEC-CUBE:4.3from
Open
受注管理:受注一覧の対応状況変更の変更できませんのメッセージの番号が画面上にない #6506 の修正#6507systemfriend-tsuji wants to merge 1 commit intoEC-CUBE:4.3from
systemfriend-tsuji wants to merge 1 commit intoEC-CUBE:4.3from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.3 #6507 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 480 480
Lines 26512 26512
=======================================
Hits 21930 21930
Misses 4582 4582
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@systemfriend-tsuji |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
#6506 の修正です。
方針(Policy)
画面上に表示されていない番号でしたので、ひとまず画面上に表示されている番号に切り替える
実装に関する補足(Appendix)
受注ステータスの更新時のエラーメッセージで、画面上にない出荷IDが表示されていましたので
受注Noに変更しました。
テスト(Test)
出荷IDと受注Noが異なる受注を対応中に変更し
購入処理中の受注でも同様に、受注と同じ対応状況のステータスと移動できないステータスを指定して確認しました。
相談(Discussion)
今回、受注Noに変更しましたが、
受注一覧が出荷データの一覧になっていますので
表示する受注Noが表示されている部分に出荷IDに関係するデータも表示し
エラーメッセージで該当行を示せるようにしたほうが良いかもしれません。
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目