[maintenance/4.1] GitHub Actionsワークフローを最新バージョンに更新#6608
Draft
dotani1111 wants to merge 215 commits intoEC-CUBE:maintenance/4.1from
Draft
[maintenance/4.1] GitHub Actionsワークフローを最新バージョンに更新#6608dotani1111 wants to merge 215 commits intoEC-CUBE:maintenance/4.1from
dotani1111 wants to merge 215 commits intoEC-CUBE:maintenance/4.1from
Conversation
Bumps [twig/twig](https://github.com/twigphp/Twig) from 2.14.10 to 2.14.11. - [Release notes](https://github.com/twigphp/Twig/releases) - [Changelog](https://github.com/twigphp/Twig/blob/v2.14.11/CHANGELOG) - [Commits](twigphp/Twig@v2.14.10...v2.14.11) --- updated-dependencies: - dependency-name: twig/twig dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
パスワードを変更してしまうと、 OWASP ZAP の自動ログインが無効になり、 アクティブスキャンが継続できなくなってしまうため、パスワードの変更を抑 制するパッチを当てる必要がある
[4.1]jQuery.text() を使用するよう修正
[4.1]ファイル名チェック修正
バージョンを更新:4.1.2-p1
Bumps [engine.io](https://github.com/socketio/engine.io) and [browser-sync](https://github.com/BrowserSync/browser-sync). These dependencies needed to be updated together. Updates `engine.io` from 3.5.0 to 6.2.0 - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md) - [Commits](socketio/engine.io@3.5.0...6.2.0) Updates `browser-sync` from 2.27.7 to 2.27.10 - [Release notes](https://github.com/BrowserSync/browser-sync/releases) - [Changelog](https://github.com/BrowserSync/browser-sync/blob/master/CHANGELOG.md) - [Commits](BrowserSync/browser-sync@v2.27.7...v2.27.10) --- updated-dependencies: - dependency-name: engine.io dependency-type: indirect - dependency-name: browser-sync dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…engine.io-and-browser-sync-6.2.0 Bump engine.io and browser-sync
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) and [gulp-notify](https://github.com/mikaelbr/gulp-notify). These dependencies needed to be updated together. Updates `node-notifier` from 5.4.5 to 9.0.1 - [Release notes](https://github.com/mikaelbr/node-notifier/releases) - [Changelog](https://github.com/mikaelbr/node-notifier/blob/master/CHANGELOG.md) - [Commits](mikaelbr/node-notifier@v5.4.5...v9.0.1) Updates `gulp-notify` from 3.2.0 to 4.0.0 - [Release notes](https://github.com/mikaelbr/gulp-notify/releases) - [Changelog](https://github.com/mikaelbr/gulp-notify/blob/master/CHANGELOG.md) - [Commits](https://github.com/mikaelbr/gulp-notify/commits/v4.0.0) --- updated-dependencies: - dependency-name: node-notifier dependency-type: indirect - dependency-name: gulp-notify dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…node-notifier-and-gulp-notify-9.0.1 Bump node-notifier and gulp-notify
[4.1]テキストのみのデータは jQuery.text を使用する
[4.1] JavaScript で出力する文字列にエスケープ処理を追加
[4.1]file.file_path のサニタイズ
- Merge 4.1 branch changes into maintenance/4.1 - Resolved conflicts: - Dockerfile: Keep Node.js 18.x and composer self-update - Constant.php: Keep version 4.1.2-p4 - package.json: Keep version 4.1.2-p4 - composer.lock, package-lock.json: Use 4.1 branch versions
- actions/cacheをv1からv4に更新 - actions/upload-artifactをv2からv6に更新 - actions/checkoutをv2からv6に更新 - actions/download-artifactをv2からv7に更新 - codecov/codecov-actionをv1からv5に更新 - svenstaro/upload-release-actionをv1-releaseから2.11.3に更新 - chromedriverコマンドに--port=9515オプションを追加
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Comment |
- GitHub Actionsのset-outputをGITHUB_OUTPUTに変更(10ファイル) - 非推奨のset-outputコマンドを新しいGITHUB_OUTPUT方式に更新 - actions/cache@v4使用時の警告を解消 - Codeceptionテストの安定化を改善 - AbstractPage::goPage()にwaitForJSを追加してページ遷移を確実に待機 - AbstractAdminPage::goPage()にwaitとリトライロジックを追加 - AbstractAdminPage::atPage()でsee()をwaitForText()に変更 - StaleElementReferenceExceptionの発生を防止
Contributor
Author
|
Backward系のテストはもういらない気がする。 |
Contributor
Author
|
[Facebook\WebDriver\Exception\StaleElementReferenceException] stale element reference: stale element not found SeleniumとFacebook WebDriveの通信ができないようなので、調べてみる。 |
02036d0 to
83dfd5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
GitHub Actionsのワークフローファイルを最新バージョンに更新しました。
4.3ブランチと同様の更新を行い、最新のGitHub Actions機能とセキュリティ改善に対応しています。
主な変更内容:
更新したファイル(12ファイル):
方針(Policy)
実装に関する補足(Appendix)
更新したアクションの詳細
actions/cache: v1 → v4 (14箇所)actions/upload-artifact: v2 → v6 (29箇所)actions/checkout: v2 → v6 (4箇所)actions/download-artifact: v2 → v7 (1箇所)codecov/codecov-action: v1 → v5 (2箇所)svenstaro/upload-release-action: v1-release → 2.11.3 (8箇所)chromedriverのポート指定
すべてのchromedriverコマンドに
--port=9515オプションを追加しました。これにより、ポートの明示的な指定により接続の安定性が向上します。テスト(Test)
GitHub Actionsのワークフローファイルの更新のみで、アプリケーションコードの変更はありません。
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目