Merged
Conversation
…fony 7.x - Apply ControllerMethodInjectionToConstructorRector to migrate method injection to constructor injection - Apply ClassPropertyAssignToConstructorPromotionRector for promoted properties - Apply RemoveUnusedPromotedPropertyRector and RecastingRemovalRector - Fix readonly property conflicts in controllers extending AbstractController (PageController, EditController, ShoppingController, ProductController) Made-with: Cursor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ts and simplifying method calls - Removed unused phpstan ignore comments in various entity classes and services. - Simplified method call in LayoutController by removing an unnecessary parameter.
…pdates - Added phpstan/extension-installer (version 1.4.3) for automatic installation of PHPStan extensions. - Updated phpstan/phpstan to version 2.1.44. - Added phpstan/phpstan-doctrine (version 2.0.20) for Doctrine extensions support. - Updated content hash for the lock file.
- Updated type hints in Configuration, Cart, and CsvImportService classes for better clarity and type safety. - Added new method getErrors() in Cart class to retrieve error details. - Improved handling of column headers in CsvImportService for better type definition. - Simplified random string generation in StringUtil by using random_bytes. - Added phpstan ignore comments for nullable associations in DeliveryFee and LoginHistory entities.
- Upgraded composer/ca-bundle to version 1.5.10. - Upgraded composer/class-map-generator to version 1.7.1 with updated Symfony finder requirements. - Upgraded composer/composer to version 2.9.5. - Upgraded doctrine/collections to version 2.6.0. - Upgraded doctrine/dbal to version 3.10.5.
simplify code structure and improve readability - Removed unnecessary else statements in various controllers and services to streamline code flow. - Enhanced readability by directly returning values instead of using else blocks. - Updated php-cs-fixer configuration to allow unsupported PHP versions. - Added a new Rector rule for handling nullable arguments in PHPUnit tests.
update PHPUnit test cases to remove #[\Override] attributes
update PHPUnit rules and clean up code - RemoveParentDelegatingConstructorRector - NullToStrictStringFuncCallArgRector - ExpressionCreateMockToCreateStubRector - RecastingRemovalRector - AddOverrideAttribute - RemoveVoidDocblock - RemoveUselessVarTag - AssertEqualsToSameRector - LiteralGetToRequestClassConstantRector
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.3-symfony7 #6690 +/- ##
================================================
- Coverage 82.44% 82.28% -0.16%
================================================
Files 482 482
Lines 25701 25711 +10
================================================
- Hits 21188 21156 -32
- Misses 4513 4555 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- AddInstanceofAssertForNullableArgumentRector::class, - InlineStubPropertyToCreateStubMethodCallRector::class, - PropertyCreateMockToCreateStubRector::class, - ControllerMethodInjectionToConstructorRector::class, - CreateStubOverCreateMockArgRector::class,
- Removed unused Rector rules for dead code and PHP 7/8 compatibility. - Added AttributeArgumentsOrderRector and NormalizePhpDocArrayGenericSpacingRector for improved coding style. - Updated Symfony container XML comment for clarity.
nanasess
approved these changes
Apr 1, 2026
Contributor
Author
|
ControllerMethodInjectionToConstructorRectorについては、特定のファイルでの除外などの方針で試す。 |
Contributor
Author
|
ControllerMethodInjectionToConstructorRectorをInstallControllerに当ててた状態で、テストを実行すると以下のエラーが発生します。 |
…tructorRector をパス指定でスキップ
Contributor
Author
|
テスト通ったのでマージしますー。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
Rectorを適用しました。
方針(Policy)
実装に関する補足(Appendix)
テスト（Test)
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目