Skip to content

ENCD-4225 remove reviewer_comment #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mingjiecn wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

ENCD-4225 remove reviewer_comment #4212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5df1f5
remove reviewer_comment
mingjiecn Dec 9, 2021
77eb125
Merge branch 'dev' into ENCD-4225-remove-reviewer-comment
mingjiecn Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/encoded/schemas/changelogs/mixins.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@
* Added *GRO-cap*, *GRO-seq*, and *long read single-cell RNA-seq* to *assay_term_name* enum; *single-nucleus RNA-seq* and *genotyping by high throughput sequencing assay* were removed and remapped to *single-cell RNA sequencing assay* and *whole genome sequencing assay* respectively
* Removed *single-cell ATAC-seq* from *assay.assay_term_name* enum and remapped to *single-nucleus ATAC-seq*
* Added *LC/MS label-free quantitative proteomics*, *LC-MS/MS isobaric label quantitative proteomics*, and *Ribo-seq* to *assay_term_name* enum. *assay_term_name* enum *Capture Hi-C* was changed to *capture Hi-C*
* Added *charles-lee* to *aliases.aliases.items* pattern
* Removed *reviewer_comment from *review properties
* Added *charles-lee* to *aliases.aliases.items* pattern
6 changes: 0 additions & 6 deletions src/encoded/schemas/mixins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,12 +203,6 @@
"description": "Person from the reviewing lab who reviewed the data.",
"type": "string",
"linkTo": "User"
},
"reviewer_comment": {
"title": "Reviewer comment",
"description": "Additional information specified by the reviewer.",
"type": "string",
"pattern": "^(\\S+(\\s|\\S)*\\S+|\\S)$"
}
}
}
Expand Down