Clean up testing/contributing

[jasonb5]

Description

• Cleans up contribute-guide.rst.
• Cleans up CONTRIBUTING.md.
• Removes scripts_regression_tests.py, replaced by pytest.
• Remove old code_checker.py, replaced by pylint via pre-commit.

---

• Closes Testing instructions in CONTRIBUTING.md are incorrect/incomplete #4936

Checklist

• My code follows the style guidelines of this project (black formatting)
• I have performed a self-review of my own code
• My changes generate no new warnings
• I have added tests that exercise my feature/fix and existing tests continue to pass
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding additions and changes to the documentation

[github-actions]

You can preview documentation at https://esmci.github.io/cime/branch/remove-scripts-regression/html/index.html

[billsacks]

Thanks a lot for this cleanup!

[samsrabin]

@billsacks Were you able to get the container to work? I tried on Casper with podman, and it just stopped after a bunch of "Copying blob ... Done" messages.

podman run -it --rm --hostname docker -e CIME_MODEL=cesm -v $PWD:/root/model -v ./storage:/root/storage -w /root/model/cime ghcr.io/esmci/cime:latest bash

[billsacks]

Were you able to get the container to work?

No, I haven't tried it yet.

[jasonb5]

@samsrabin Go ahead and give podman another try.

[samsrabin]

My command from above, podman run -it --rm --hostname docker -e CIME_MODEL=cesm -v $PWD:/root/model -v ./storage:/root/storage -w /root/model/cime ghcr.io/esmci/cime:latest bash, errors:

...
Copying blob 241cf71de727 done
Copying config 80c3a13b36 done
Writing manifest to image destination
Storing signatures
Error: lstat storage: no such file or directory

Based on the README, podman run -it --name cime --hostname docker cime:latest bash errors:

Killed

Do I actually need to build the container first?

Based on the README, podman build -t cime:latest --target base docker/ errors:

Error: The target "base" was not found in the provided Dockerfile

[jasonb5]

My command from above, podman run -it --rm --hostname docker -e CIME_MODEL=cesm -v $PWD:/root/model -v ./storage:/root/storage -w /root/model/cime ghcr.io/esmci/cime:latest bash, errors:

You need to create the storage directory. I'll add a note.

...
Copying blob 241cf71de727 done
Copying config 80c3a13b36 done
Writing manifest to image destination
Storing signatures
Error: lstat storage: no such file or directory

Based on the README, podman run -it --name cime --hostname docker cime:latest bash errors:

Killed

I'll retest this, could come down to how podman is configured on the host systems.

Do I actually need to build the container first?

Based on the README, podman build -t cime:latest --target base docker/ errors:

Error: The target "base" was not found in the provided Dockerfile

You only need to build if you use cime:latest in the run command. If you use ghcr.io/esmci/cime:latest, you do not need to build it. I'll make a note and fix the docs --target base is not longer valid, thought i had removed that.

[samsrabin]

Here's what podman run -it --rm --hostname docker -e CIME_MODEL=cesm -v $PWD:/root/model -v ./storage:/root/storage -w /root/model/cime ghcr.io/esmci/cime:latest bash gives after making the ./storage/ dir:

WARN[0000] "/" is not a shared mount, this could cause issues or missing mounts with rootless containers
ERRO[0000] cannot find UID/GID for user samrabin: no subuid ranges found for user "samrabin" in /etc/subuid - check rootless mode in man pages.
WARN[0000] Using rootless single mapping into the namespace. This might break some images. Check /etc/subuid and /etc/subgid for adding sub*ids if not using a network user
Trying to pull ghcr.io/esmci/cime:latest...
Getting image source signatures
Copying blob 3389cef86b02 done
Copying blob 864b5d8389d3 done
Copying blob 3389cef86b02 done
Copying blob 864b5d8389d3 done
Copying blob 2fa6810b0015 done
Copying blob 69c465742a24 done
Copying blob b63086c15211 done
Copying blob 01d7766a2e4a done
Copying blob 4f4fb700ef54 done
Copying blob 09e9d8c5083d done
Copying blob b34a077279f4 done
Copying blob 0471751fdc8a done
Copying blob d2b01bdade94 done
Copying blob abe7a1dd0952 done
Copying blob f22f7c9cbb42 done
Copying blob 6eac5c0dbe07 done
Copying blob 9cd9c8434f59 done
Copying blob 510d1236984f done
Copying blob dbee995f199a done
Copying blob 241cf71de727 done
Error: copying system image from manifest list: writing blob: adding layer with blob "sha256:01d7766a2e4a62b74e0bebf2cd12c47e675e9221174f6570854203e84ffe68b0": ApplyLayer stdout:  stderr: setting up pivot dir: mkdir /glade/u/home/samrabin/.local/share/containers/storage/vfs/dir/efafae78d70c98626c521c246827389128e7d7ea442db31bc433934647f0c791/.pivot_root3042858666: permission denied exit status 1

[samsrabin]

Updates:

1. Looks like the Killed message happens on Casper login nodes, but not Casper compute (interactive) nodes or Derecho login nodes.
2. The error in my previous post happens on Derecho, but not on a Casper compute node. However, on the latter I just get:

ERRO[0000] cannot find UID/GID for user samrabin: no subuid ranges found for user "samrabin" in /etc/subuid - check rootless mode in man pages.
WARN[0000] Using rootless single mapping into the namespace. This might break some images. Check /etc/subuid and /etc/subgid for adding sub*ids if not using a network user
Trying to pull ghcr.io/esmci/cime:latest...
Getting image source signatures
Copying blob 3389cef86b02 done
Copying blob 864b5d8389d3 done
Copying blob 69c465742a24 done
Copying blob b63086c15211 done
Copying blob 2fa6810b0015 done
Copying blob 01d7766a2e4a done
Copying blob 4f4fb700ef54 done
Copying blob 09e9d8c5083d done
Copying blob b34a077279f4 done
Copying blob 0471751fdc8a done
Copying blob d2b01bdade94 done
Copying blob abe7a1dd0952 done
Copying blob 6eac5c0dbe07 done
Copying blob f22f7c9cbb42 done
Copying blob 9cd9c8434f59 done
Copying blob 510d1236984f done
Copying blob dbee995f199a done
Copying blob 241cf71de727 done

and then it ends, returning me to the prompt.