Remove star imports#4983
Draft
jasonb5 wants to merge 7 commits into
Draft
Conversation
…ails Rewrite plan.md, implementation.md, and README.md to reflect the reorganize-don't-rewrite philosophy, utils.py distribution strategy, cross-cutting issues inventory, and Case two-phase refactoring approach.
…trap module Add CIME.core.exceptions with CIMEError and typed subclasses (ConfigurationError, BuildError, SubmitError, etc.). CIMEError preserves dual SystemExit+Exception inheritance for traceback suppression. Add CIME.core.config.bootstrap with centralized sys.path management (bootstrap_cime, find_cimeroot, check_minimum_python_version). Include 40 unit tests with 98% coverage.
Replace the CIMEError class definition in utils.py with a re-export from CIME.core.exceptions for backward compatibility. Update 19 internal callers to import CIMEError directly from CIME.core.exceptions. External consumers using 'from CIME.utils import CIMEError' or 'utils.CIMEError' continue to work unchanged via the re-export.
Contributor
|
You can preview documentation at https://esmci.github.io/cime/branch/fix/refactor-star-imports/html/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
from CIME.XML.standard_module_setup import *to explicit importsfrom CIME.test_status import *to explicit importsstandard_module_setup.pyandstandard_script_setup.pyfor backward compatibility with external codeDepends on: #4982
Checklist