Fix array out of bounds for large arrays (#124)#125
Open
rishabhvaish wants to merge 1 commit intoEVerest:mainfrom
Open
Fix array out of bounds for large arrays (#124)#125rishabhvaish wants to merge 1 commit intoEVerest:mainfrom
rishabhvaish wants to merge 1 commit intoEVerest:mainfrom
Conversation
In commit 871fcb3, the condition 'if skip_to_end and m < _max' was simplified to 'if skip_to_end', causing the final array grammar to be skipped when the LOOP optimization activates. Fixes EVerest#124 Signed-off-by: Rishabh Vaish <rishabhvaish.904@gmail.com>
rishabhvaish
force-pushed
the
fix/array-out-of-bounds-124
branch
from
2ad8358 to
e457f92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
m < _maxguard in the array grammar loop that was accidentally removed in commit 871fcb3EXI_ERROR__ARRAY_OUT_OF_BOUNDSwhen decoding arrays at their configured maximum size (e.g., ChargeParameterDiscoveryRes with 16 PMaxScheduleEntry elements)Test plan
Fixes #124