Pathfinder Command: fix GCC 15 -Wnonnull warning #3538
Conversation
|
uhm thanks for your contribution. I'm curious and will check what happens in the upstream code right now first o_O |
|
Jenkins: test this please |
|
Yeah this does indeed crash. Unfortunately your assignment does not compile. We have some platforms (notable 3DS) where https://ci.easyrpg.org/job/player-3ds-pr/592/console (Besides, but thats something for me to fix, I noticed that in general that code doesn't do what is intended. When you e.g. pass in "Variable 5" this should start reading the array from location 5. Instead it dereferences the Variable and then starts the array their.) |
`event_id_ignore_list.begin()` pointed at an empty vector.
baabadd to
4aef33b
Compare
|
Replaced assignment with std::vector<int8_t> into;
std::vector<int64_t> from;
std::copy(from.begin(), from.end(), std::back_inserter(into));I don't know whether checking that the value fits makes sense in this context. I assume |
|
Jenkins: Test this please Actually it is 32 Bit. Its just on most systems |
…cc15_warning Pathfinder Command: fix GCC 15 -Wnonnull warning
event_id_ignore_list.begin()pointed at an empty vector. I don't have a game to test this with, but it looks like it should not have worked before.