feat: upgrade to pydantic v2 compatibility#3
Merged
Conversation
- Replace validate_arguments with validate_call (renamed in pydantic v2) - Replace Field(const=True) with Field(default=...) (const removed in v2) - Bump pydantic requirement from >=1.10.5,<2 to >=2 Other v1 patterns (.dict(), .parse_obj(), class Config, @validator) still work in pydantic v2 via its built-in compatibility layer.
Python 3.7 and 3.8 are EOL and unavailable on ubuntu-latest (24.04), causing CI failures. Pydantic v2 requires >=3.8 anyway. Also add fail-fast: false so one matrix failure doesn't cancel the rest.
CI installs from requirements.txt, not pyproject.toml. The old pydantic<2 constraint was still there, causing validate_call import failures.
johndagostino
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@validate_argumentswith@validate_call(renamed in pydantic v2) across 7 API filesField(const=True)withField(default=...)in 2 model files (constremoved in v2)>=1.10.5, <2to>=2Other v1 patterns (
.dict(),.parse_obj(),class Config,@validator) still work in pydantic v2 via its built-in compatibility layer with deprecation warnings. A full migration to v2 native APIs can be done separately.Why
The main Edrolo project needs
claude-agent-sdkwhich depends onmcpwhich requirespydantic>=2. This<2upper bound on pywonde was the blocker.Test plan
🤖 Generated with Claude Code