Refactor blob capture and extraction to support capture folder and post-rotation handling#31
Merged
Conversation
…st-rotation handling - Updated `BlobFsCapture` to accept a `capture_folder` parameter for storing rotated blobs. - Modified `rotate` method to move the current blob to the specified capture folder. - Enhanced `CompositeBlobCapture` to manage post-rotation blobs and ensure follow-up frames are captured correctly. - Adjusted `BlobExtractor` to handle multiple blob files, including extracting from tar archives. - Updated tests to verify new behavior for blob rotation, extraction, and completion handler calls. - Refactored argument parsing in `add_args` to include `--blob-capture-folder` option.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlobFsCaptureto accept acapture_folderparameter for storing rotated blobs.rotatemethod to move the current blob to the specified capture folder.CompositeBlobCaptureto manage post-rotation blobs and ensure follow-up frames are captured correctly.BlobExtractorto handle multiple blob files, including extracting from tar archives.add_argsto include--blob-capture-folderoption.