Skip to content

Add governed Clippy policy baseline#262

Open
EffortlessSteven wants to merge 1 commit into
mainfrom
codex/implement-standard-clippy-policy-for-rust-repos-ovnxm5
Open

Add governed Clippy policy baseline#262
EffortlessSteven wants to merge 1 commit into
mainfrom
codex/implement-standard-clippy-policy-for-rust-repos-ovnxm5

Conversation

@EffortlessSteven
Copy link
Copy Markdown
Member

Motivation

  • Establish a single, governed Clippy baseline for the workspace (panic-free tests, no silent failures, AST/slice safety, suppression governance) and track planned Rust 1.94/1.95 flips.
  • Provide machine-readable policy and debt ledgers plus semantic allowlists so exceptions are structured, reviewable, and expiring.
  • Surface policy verification in the repo xtask so CI/local checks can validate inheritance, MSRV alignment, and allowlist/debt hygiene.

Description

  • Ratchets workspace MSRV to 1.93 and adds workspace-level lint blocks under [workspace.lints.rust] and [workspace.lints.clippy] in the root Cargo.toml.
  • Adds policy artifacts policy/clippy-lints.toml, policy/clippy-debt.toml, policy/no-panic-allowlist.toml, and policy/non-rust-allowlist.toml as the machine-readable ledger and placeholders for debt/allowlists.
  • Adds documentation docs/CLIPPY_POLICY.md, updates clippy.toml (repo-local config, `msrv =

Codex Task

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 54 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9cc1db27-ef4c-4a4d-b269-caacf25d78cb

📥 Commits

Reviewing files that changed from the base of the PR and between 607f501 and 350f420.

📒 Files selected for processing (105)
  • Cargo.toml
  • clippy.toml
  • crates/flight-ac7-input/Cargo.toml
  • crates/flight-ac7-protocol/Cargo.toml
  • crates/flight-ac7-telemetry/Cargo.toml
  • crates/flight-adapter-common/Cargo.toml
  • crates/flight-aerofly/Cargo.toml
  • crates/flight-axis/Cargo.toml
  • crates/flight-bdd-metrics/Cargo.toml
  • crates/flight-blackbox/Cargo.toml
  • crates/flight-bus/Cargo.toml
  • crates/flight-cli/Cargo.toml
  • crates/flight-cloud-profiles/Cargo.toml
  • crates/flight-core/Cargo.toml
  • crates/flight-dcs-bios/Cargo.toml
  • crates/flight-dcs-export/Cargo.toml
  • crates/flight-dcs-modules/Cargo.toml
  • crates/flight-device-common/Cargo.toml
  • crates/flight-elite/Cargo.toml
  • crates/flight-falcon-bms/Cargo.toml
  • crates/flight-ffb-brunner/Cargo.toml
  • crates/flight-ffb-moza/Cargo.toml
  • crates/flight-ffb-vpforce/Cargo.toml
  • crates/flight-ffb/Cargo.toml
  • crates/flight-headless/Cargo.toml
  • crates/flight-hid-support/Cargo.toml
  • crates/flight-hid-types/Cargo.toml
  • crates/flight-hid/Cargo.toml
  • crates/flight-hotas-brunner/Cargo.toml
  • crates/flight-hotas-ch/Cargo.toml
  • crates/flight-hotas-honeycomb/Cargo.toml
  • crates/flight-hotas-logitech-wheel/Cargo.toml
  • crates/flight-hotas-logitech/Cargo.toml
  • crates/flight-hotas-microsoft/Cargo.toml
  • crates/flight-hotas-saitek/Cargo.toml
  • crates/flight-hotas-simucube/Cargo.toml
  • crates/flight-hotas-sony/Cargo.toml
  • crates/flight-hotas-thrustmaster/Cargo.toml
  • crates/flight-hotas-turtlebeach/Cargo.toml
  • crates/flight-hotas-virpil/Cargo.toml
  • crates/flight-hotas-vkb/Cargo.toml
  • crates/flight-hotas-vpforce/Cargo.toml
  • crates/flight-hotas-winwing/Cargo.toml
  • crates/flight-il2/Cargo.toml
  • crates/flight-installer-tests/Cargo.toml
  • crates/flight-integration-tests/Cargo.toml
  • crates/flight-ipc/Cargo.toml
  • crates/flight-ksp/Cargo.toml
  • crates/flight-macos-hid/Cargo.toml
  • crates/flight-metrics-http/Cargo.toml
  • crates/flight-metrics/Cargo.toml
  • crates/flight-motion/Cargo.toml
  • crates/flight-open-hardware/Cargo.toml
  • crates/flight-opentrack/Cargo.toml
  • crates/flight-openxr/Cargo.toml
  • crates/flight-panels-core/Cargo.toml
  • crates/flight-panels-cougar/Cargo.toml
  • crates/flight-panels-goflight/Cargo.toml
  • crates/flight-panels-saitek/Cargo.toml
  • crates/flight-panels/Cargo.toml
  • crates/flight-pedals/Cargo.toml
  • crates/flight-plugin/Cargo.toml
  • crates/flight-prepar3d/Cargo.toml
  • crates/flight-process-detection/Cargo.toml
  • crates/flight-profile/Cargo.toml
  • crates/flight-psx/Cargo.toml
  • crates/flight-replay/Cargo.toml
  • crates/flight-rules/Cargo.toml
  • crates/flight-scheduler/Cargo.toml
  • crates/flight-security/Cargo.toml
  • crates/flight-service/Cargo.toml
  • crates/flight-session/Cargo.toml
  • crates/flight-sim-racing/Cargo.toml
  • crates/flight-simconnect-sys/Cargo.toml
  • crates/flight-simconnect/Cargo.toml
  • crates/flight-streamdeck/Cargo.toml
  • crates/flight-tactile/Cargo.toml
  • crates/flight-test-helpers/Cargo.toml
  • crates/flight-testkit/Cargo.toml
  • crates/flight-tracing/Cargo.toml
  • crates/flight-trackir/Cargo.toml
  • crates/flight-ui/Cargo.toml
  • crates/flight-units/Cargo.toml
  • crates/flight-updater/Cargo.toml
  • crates/flight-virtual/Cargo.toml
  • crates/flight-vr-overlay/Cargo.toml
  • crates/flight-vr/Cargo.toml
  • crates/flight-warthunder/Cargo.toml
  • crates/flight-watchdog/Cargo.toml
  • crates/flight-wingman/Cargo.toml
  • crates/flight-workspace-meta/Cargo.toml
  • crates/flight-writers/Cargo.toml
  • crates/flight-xplane-plugin/Cargo.toml
  • crates/flight-xplane/Cargo.toml
  • docs/CLIPPY_POLICY.md
  • examples/Cargo.toml
  • installer/Cargo.toml
  • policy/clippy-debt.toml
  • policy/clippy-lints.toml
  • policy/no-panic-allowlist.toml
  • policy/non-rust-allowlist.toml
  • specs/Cargo.toml
  • xtask/Cargo.toml
  • xtask/src/lint_policy.rs
  • xtask/src/main.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/implement-standard-clippy-policy-for-rust-repos-ovnxm5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member Author

Not auto-merging in this PR review pass. This appears to be a near-duplicate codex variant of #261 — same Clippy baseline scope, similar MSRV bump (1.93), similar policy/ ledger files (1789 additions across 105 files vs. 1081 across 121). The PR body is also truncated mid-sentence in the "Description" section.

See the comment on #261 for the substantive concerns about merging an MSRV bump + workspace-wide lint baseline + known-failing-gate combination in a single PR. Recommend picking the cleaner of the two variants, splitting it into a "scaffold only" PR that lands cleanly, then doing the [lints] workspace = true flip in follow-ups once existing debt is addressed.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant