Follow-up: extend PR fixes, forward-port #67, consolidate xtask migration

[EffortlessSteven]

Summary

Consolidated follow-up work from the PR review/merge pass. Each commit either forward-ports a merge-conflicting PR or extends a partial fix that the original PR didn't cover end-to-end.

• fix(test): add missing topic field to remaining RoutePattern initializers — extends fix(test): add missing topic field to RoutePattern #256 (which only fixed integration_bus.rs) by adding the same Topic::Any field to the 22 other RoutePattern { ... } sites in bus_depth_tests.rs, depth_tests.rs, and mutation_killing_tests.rs. Without this, the flight-bus test target still fails to compile after fix(test): add missing topic field to RoutePattern #256.
• fix(ci): increase validate/test timeouts for 100-crate workspace — forward-port of fix(ci): increase job timeouts for 100-crate workspace #67, which conflicted on ci.yml after fix(ci): handle cargo-public-api JSON format compatibility #74 rewrote the public-API guard section. Raises Validation Pipeline to 45 min and Test Suite to 30/45 min (Linux/Windows) as fix(ci): increase job timeouts for 100-crate workspace #67 intended.
• chore(xtask): convert maintenance helpers to first-class xtask commands — picks the cleanest subset from the four codex variants (Convert utility scripts to Rust and add xtask build/fix commands #279–Convert Python helpers to Rust xtasks #282) and applies it on top of current main. Adds cargo xtask fix-front-matter, license-inventory, wix-images, drops the replaced scripts/fix_front_matter.py, scripts/generate_license_inventory.ps1, and installer/wix/generate-images.py, and updates installer/wix/README.md to point at the new command. Dropped each variant's xtask/src/validate.rs change because it pre-dated fix(ci): handle cargo-public-api JSON format compatibility #74 and would have reverted the rustdoc JSON format-error handling, and dropped each variant's stale duplicate test fixes because those merged via fix(clippy): replace single-match with if let in profile_linter #255–fix(test): update MockHotplugMonitor usage #257 / Add degradation_reasons field to SafeModeDiagnostic #259.

Test plan

• cargo test -p flight-bus --tests — bus tests compile and pass after RoutePattern fix (10 + 11 tests across affected files green)
• cargo build -p xtask — workspace builds with the three new xtask modules
• cargo clippy -p xtask --no-deps -- -D warnings — clean
• cargo xtask wix-images — regenerates installer/wix/banner.bmp and dialog.bmp deterministically (byte-identical to committed BMPs)
• cargo xtask --help — lists the three new commands

Related

Squash-merged this pass: #255, #256, #257, #258, #259, #74, #283, #285.
Closed in favour of selected variant or above commits: #67, #284, #286, #279, #280, #281, #282, #287, #288, #289, #290.
Reviewed and left open with comments for split-up: #254, #68.

---

Generated by Claude Code

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[coderabbitai]

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 6 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4b1e9361-2b59-43ef-83fa-823b553ccaaf

📥 Commits

Reviewing files that changed from the base of the PR and between 7d026c3 and d5f4648.

📒 Files selected for processing (22)

• .github/workflows/ci.yml
• Cargo.toml
• crates/flight-bus/tests/bus_depth_tests.rs
• crates/flight-bus/tests/depth_tests.rs
• crates/flight-bus/tests/mutation_killing_tests.rs
• crates/flight-cli/Cargo.toml
• crates/flight-cli/tests/common/mod.rs
• crates/flight-cli/tests/device_cmd.rs
• crates/flight-cli/tests/diag_cmd.rs
• crates/flight-cli/tests/error_handling.rs
• crates/flight-cli/tests/help_completeness.rs
• crates/flight-cli/tests/output_format.rs
• crates/flight-cli/tests/profile_cmd.rs
• crates/flight-cli/tests/version_cmd.rs
• installer/wix/README.md
• installer/wix/generate-images.py
• scripts/fix_front_matter.py
• scripts/generate_license_inventory.ps1
• xtask/src/fix_front_matter.rs
• xtask/src/license_inventory.rs
• xtask/src/main.rs
• xtask/src/wix_images.rs

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/review-merge-prs-LyqQ2

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}