Refactor VKB test report builders and fix clippy in HID descriptor#298
Refactor VKB test report builders and fix clippy in HID descriptor#298EffortlessSteven wants to merge 1 commit into
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
clippyrules for the VKB target.Description
crates/flight-hotas-vkb/tests/common/mod.rsthat provide reusable builders likejoystick_report,stecs_report,stecs_mt_report,sem_thq_report,t_rudder_report, andwith_report_id.crates/flight-hotas-vkb/tests/depth_tests.rs,parse_property_tests.rs,snapshot_tests.rs, andvkb_protocol_depth.rs) to import and use the shared builders instead of local duplicated constructors.Veconly where needed (.to_vec()), preventing misuse of array APIs.match/ifarm incrates/flight-hid-support/src/hid_descriptor.rs(global usage page case) to satisfyclippy::collapsible_match.Testing
rustfmt --checkon modified files and it passed.cargo test -p flight-hotas-vkb(unit/proptest/depth/snapshot suites for the crate) and all tests passed.cargo clippy -p flight-hotas-vkb --all-targets -- -D warningsand the linter passed with no warnings.Codex Task