Make telemetry packet helpers DRY#299
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
Description
encode_telemetry_frame+ small write helpers tocrates/flight-aerofly/src/lib.rsand update the binary parser to use the offsets instead of numeric literals.encode_packet+write_f64_letocrates/flight-opentrack/src/lib.rsand update the parser to use the offsets.encode_telemetry_frame/encode_packetfrom the library instead of duplicating byte writes in test helpers (crates/flight-aerofly/tests/*,crates/flight-opentrack/tests/*).sort_by(|a,b| b.timestamp.cmp(&a.timestamp))calls withsort_by_key(|b| Reverse(b.timestamp))incrates/flight-writers/src/curve_conflict.rsandcrates/flight-writers/src/rollback.rsto satisfy Clippy suggestions.Testing
git diff --check(no leftover check errors) — passed.cargo test -p flight-aerofly -p flight-opentrackand the unit/depth/integration tests for both crates passed (all tests green).cargo clippy -p flight-aerofly -p flight-opentrack -- -D warningsand Clippy passed for the touched crates.cargo fmt --all -- --checkwas attempted but the workspace contains unrelated formatting diffs outside this change set, so a workspace-wide strict format check could not be used here.Codex Task