fix: Accessibility improvements for Dropdown#1055
Closed
kheinrich-eightfold wants to merge 1 commit intomainfrom
Closed
fix: Accessibility improvements for Dropdown#1055kheinrich-eightfold wants to merge 1 commit intomainfrom
kheinrich-eightfold wants to merge 1 commit intomainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
==========================================
+ Coverage 84.10% 84.12% +0.01%
==========================================
Files 1146 1146
Lines 20942 20940 -2
Branches 7921 7921
==========================================
+ Hits 17614 17616 +2
+ Misses 3240 3236 -4
Partials 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing as these changes are out of date, and the remaining issues from this PR have been resolved in #1104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
This PR fixes an accessibility issue surfaced in a few place in the UI with associated JIRA tickets.
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-162951
https://eightfoldai.atlassian.net/browse/ENG-162959
https://eightfoldai.atlassian.net/browse/ENG-162978
https://eightfoldai.atlassian.net/browse/ENG-163006
https://eightfoldai.atlassian.net/browse/ENG-163088
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN: