[debug] Test Octuple PR build by kheinrich-eightfold · Pull Request #1107 · EightfoldAI/octuple

kheinrich-eightfold · 2026-03-23T16:19:16Z

SUMMARY:

Note: This PR is just for testing

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

CHANGE TYPE:

Bugfix Pull Request
Feature Pull Request

TEST COVERAGE:

Tests for this change already exist
I have added unittests for this change

TEST PLAN:

codesandbox-ci · 2026-03-23T16:22:14Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov · 2026-03-23T16:23:15Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.13%. Comparing base (66efd17) to head (d82f3bf).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/components/Button/Button.tsx	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
- Coverage   84.14%   84.13%   -0.01%     
==========================================
  Files        1146     1146              
  Lines       21179    21183       +4     
  Branches     8053     8055       +2     
==========================================
+ Hits        17821    17823       +2     
- Misses       3271     3272       +1     
- Partials       87       88       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

factory-droid

PR Description:
Adds a title attribute and click logging to the Button component for testing purposes. The title attribute displays button text wrapped in question marks (?text?) and is implemented in the Button.tsx file. This change resulted in updates to numerous component snapshot tests due to the Button component's widespread usage throughout the library. ¹

Click For Summary of Files

Summary of Files

Files Modified

src/components/Table/Tests/__snapshots__/Table.pagination.accepttrue.shot

Updated Table pagination snapshot tests to reflect new Button component title attribute:

- Added title="?1?" attribute to active pagination buttons
- Updated attribute and prefix definitions to include title property for undefined states
- Preserved existing button accessibility attributes and class definitions

src/components/Table/Tests/__snapshots__/Table.pagination.renders.shot

Updated Table pagination snapshot tests to reflect new Button component title attribute:

- Added title="?1?" attribute to active pagination buttons
- Added title attribute handling in component attribute prefix definitions
- Updated multiple pagination button instances throughout the snapshot file to maintain consistency

src/components/Table/Tests/__snapshots__/Table.filter.test.js.snap

Updated Table component test snapshots to reflect new Button title attribute:

- Added title attribute to all button elements in filter test snapshots
- Set title value to "?undefined?" for elements with role="button"
- Set title value to "undefined" for related non-button elements

src/components/Button/Button.tsx

Enhanced Button component with testing and debugging features:

- Added console logging of button text on click events
- Implemented title attribute that displays button text wrapped in question marks
- Preserved existing button functionality while adding diagnostic capabilities

src/components/Dropdown/__snapshots__/Dropdown.test.tsx.snap

Added title attribute to Dropdown button snapshot test:

- Updated snapshot to include new title attribute with wrapped text pattern (?Dropdown menu test?)

src/components/Tabs/__snapshots__/Tabs.test.tsx.snap

Added title attribute to Button components in Tabs snapshot tests:

- Updated Button snapshots to include title="?undefined?" attribute for test verification purposes
- Applied consistent title attribute pattern across all stat tab button instances

src/components/OcBase/__snapshots__/OcBase.test.tsx.snap

Updated OcBase component snapshot test to include new button title attribute:

- Added title attribute with "?undefined?" value to button element in test snapshot, reflecting new accessibility and testing feature

src/components/Table/Tests/__snapshots__/Table.expand.test.tsx.snap

Updated Table component test snapshots to accommodate new Button component title attribute:

- Added title attribute to all button elements in snapshots, with text wrapped in question marks
- Updated both regular buttons (showing "?undefined?") and pagination buttons (showing "?1?")
- Modified corresponding x-attribsPrefix objects to include title attribute handling

src/components/Form/Tests/__snapshots__/Form.disabled.shot

Updated Form component test snapshots to reflect new Button component title attribute:

- Added title="?Button?" attribute to all button elements in test snapshots
- Updated x-attribs and x-attribsPrefix objects to include title attribute definitions

src/components/Stepper/Tests/__snapshots__/Stepper.test.tsx.snap

No summary generated for this file.

src/components/Table/Tests/__snapshots__/Table.pagination.position.shot

Updated Table component pagination button snapshots to include new title attributes:

- Added title="?1?" attribute to active pagination buttons
- Added title attribute handling (undefined) to button attribute collections
- Preserved existing button accessibility and styling attributes

src/components/Panel/__snapshots__/Panel.test.tsx.snap

Updated Panel component test snapshots to reflect new Button component title attribute:

- Added title attribute to all button elements with format "?text?" for testing
- Updated attribute namespace and prefix definitions to include new title attribute
- Modified snapshots for both text buttons ("?Close?") and icon-only buttons ("?undefined?")

src/components/Menu/__snapshots__/Menu.test.tsx.snap

Updated Menu component test snapshots to reflect new Button component title attributes:

- Added title attribute "?Menu dropdown?" to button elements in all Menu test cases
- Updated snapshots for large, medium, small, and default menu button variants

src/components/Skill/Tests/__snapshots__/SkillTag.test.tsx.snap

Updated Button component snapshots to include new title attribute:

- Added title="?undefined?" attribute to button elements across multiple SkillTag test scenarios including removable tags, custom buttons, and endorse buttons

src/components/Skill/Tests/__snapshots__/SkillBlock.test.tsx.snap

Added title attribute to Button components in SkillBlock snapshots:

- Updated snapshot tests to include title="?undefined?" attribute for various button types:
  - Highlight buttons
  - Custom buttons
  - Endorse buttons
  - Overflow menu buttons

src/components/DateTimePicker/Internal/Tests/__snapshots__/partial.rtl.shot

Updated Button component test snapshots to include new title attributes for testing:

- Added title attributes to all button elements in DateTimePicker snapshots:
  - Navigation buttons show "?undefined?"
  - Year selection buttons show "?1990?"
- Updated attribute namespaces and prefixes to accommodate new title property

src/components/Carousel/Tests/__snapshots__/Slide.test.tsx.snap

Updated Button component snapshots in Carousel tests to include new title attributes:

- Added title attributes to navigation buttons (Previous/Next) displaying "?undefined?"
- Added title attributes to pagination buttons displaying their respective numbers ("?1?", "?2?", "?3?")

src/components/PersistentBar/__snapshots__/PersistentBar.test.tsx.snap

Added title attributes to Button components in PersistentBar snapshots:

- Updated pagination button snapshot to include title="?1?"
- Added title="?undefined?" to system UI icon button snapshot

src/components/Accordion/__snapshots__/Accordion.test.tsx.snap

Updated snapshot tests to reflect new Button component title attribute:

- Added title="?undefined?" attribute to all button elements in Accordion component snapshots
- Updated snapshots for various Accordion states including size variations, shapes, and custom content rendering

src/components/Skeleton/__snapshots__/Skeleton.test.tsx.snap

Updated Skeleton component snapshot test to include new button title attribute:

- Added title="?Sample button?" to button element in component snapshot to reflect new Button component behavior

src/components/Table/Tests/__snapshots__/Table.sorter.test.js.snap

Updated Table component test snapshots to reflect new Button title attribute:

- Added title attribute with question mark-wrapped text (?1?) to pagination buttons
- Updated attribute prefix definitions to include title property
- Maintained existing button accessibility and styling attributes

src/components/Carousel/Tests/__snapshots__/Scroll.test.tsx.snap

Updated Carousel component snapshots to reflect new Button component title attributes:

- Added title="?undefined?" attribute to navigation buttons (Previous and Next)
- Preserved existing button attributes and structure

src/components/Menu/__snapshots__/CascadingMenu.test.tsx.snap

Added title attribute to menu button in CascadingMenu snapshot test:

- Updated snapshot to include title="?Cascading menu?" attribute on button element

src/components/Select/__snapshots__/Select.test.tsx.snap

Updated Select component test snapshots to reflect new Button component title attribute:

- Added title="?undefined?" attribute to all button elements in Select component snapshots
- Updated snapshots for various Select component states including empty options, null options, and default values
- Modified snapshots across different button variants (sizes and shapes) to include the new title attribute

src/components/Table/Tests/__snapshots__/Table.pagination.nocrashonchange.shot

Updated Table component pagination button snapshots to reflect new Button component title attribute:

- Added title attribute to pagination buttons showing page numbers in ?number? format
- Updated attribute definitions to include title in both regular and prefix configurations
- Preserved existing button accessibility attributes and class structure

src/components/Pills/__snapshots__/Pill.test.tsx.snap

Updated test snapshots to reflect new Button component title attribute:

- Added title attributes to button elements in Pill component snapshots:
  - Close button showing "?undefined?" title
  - Regular button showing "?2?" title while maintaining existing attributes

src/components/Upload/Tests/__snapshots__/uploadlist.test.tsx.snap

Updated Upload List component test snapshots to accommodate new Button component title attribute:

- Added title attributes to all button elements in test snapshots
- Set default values (wrapped in ??) to null for delete buttons and undefined for download buttons
- Updated snapshots across multiple test cases including upload status, file preview, and icon support scenarios

src/components/Button/__snapshots__/Button.test.tsx.snap

Added title attribute to Button component for testing visibility:

- Implemented title attribute across all button variants (primary, secondary, neutral, system UI)
- Added consistent title format with question mark wrapping (?text?)
- Maintained title attribute presence across different button states and sizes

src/components/Pagination/__snapshots__/Pagination.test.tsx.snap

Added title attributes to Button components in Pagination snapshots for testing purposes:

- Added title attributes to all pagination buttons, wrapping text in question marks (?text?)
- Updated snapshots for navigation buttons (Previous/Next) with ?undefined? titles
- Updated page number buttons with their respective numbers as titles (e.g. ?1?, ?2?)

Tips

Review Droid is highly customizable and comes with powerful features for augmenting your organization's code review process. Here are some tips to get the most out of it.

¹ Remove the debug console.log statement from the onClick handler. This test/debug code should not be merged into production as it clutters the console and serves no purpose for end users.

onClick={!allowDisabledFocus ? onClick : null}

Committable suggestion

Please carefully review the code before committing.

Suggested change

onClick={

!allowDisabledFocus

? (e) => {

console.log('Clicked button with text:', text);

onClick?.(e);

}

: null

}

onClick={!allowDisabledFocus ? onClick : null}

Footnotes

This suggestion is based on your review guideline: "Catch and correct any obvious bugs. Ensure code is clean, maintainable, and follows project conventions. Check for security vulnerabilities and performance issues. Avoid circular dependencies.
" ↩

factory-droid · 2026-03-23T16:28:25Z

src/components/Button/Button.tsx

+          }
          style={style}
          type={htmlType}
+          title={`?${text}?`}


¹ Remove the debug title attribute with question mark formatting. This appears to be test code that shouldn't be in production. If a title attribute is needed for accessibility, implement it as a configurable prop without debug formatting.

Committable suggestion

Please carefully review the code before committing.

Suggested change

title={`?${text}?`}

title={text}

Footnotes

This suggestion is based on your review guideline: "Catch and correct any obvious bugs. Ensure code is clean, maintainable, and follows project conventions. Check for security vulnerabilities and performance issues. Avoid circular dependencies.
" ↩

refactor: modify Button for testing

d82f3bf

factory-droid bot reviewed Mar 23, 2026

View reviewed changes

kheinrich-eightfold marked this pull request as draft March 23, 2026 17:01

kheinrich-eightfold closed this Mar 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[debug] Test Octuple PR build#1107

[debug] Test Octuple PR build#1107
kheinrich-eightfold wants to merge 1 commit intomainfrom
kheinrich/oct_build_test

kheinrich-eightfold commented Mar 23, 2026

Uh oh!

codesandbox-ci bot commented Mar 23, 2026

Uh oh!

codecov bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

factory-droid bot left a comment

Uh oh!

factory-droid bot Mar 23, 2026

Uh oh!

factory-droid bot Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

+                        onClick={
+                          !allowDisabledFocus
+                            ? (e) => {
+                                console.log('Clicked button with text:', text);
+                                onClick?.(e);
+                              }
+                            : null
+                        }

Conversation

kheinrich-eightfold commented Mar 23, 2026

SUMMARY:

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

CHANGE TYPE:

TEST COVERAGE:

TEST PLAN:

Uh oh!

codesandbox-ci bot commented Mar 23, 2026

Uh oh!

codecov bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

factory-droid bot left a comment

Choose a reason for hiding this comment

Summary of Files

Files Modified

Table of contents

⌨️ Droid Fill

Contextual PR Body Replacement

📚 Review Guidelines

Creating guidelines for Droid to follow

💬 Droid Chat

Ask questions on a PR

Follow up with Review Droid's Comments

🛠️ PR Healing

Diagnose & Fix Failures in CI

🎓 Teaching Droid

Giving Droid feedback so it learns

🔎 Review Usage

Re-Requesting Review

.droid.yaml to Configure Review Droid

Ignoring Reviews

Footnotes

Uh oh!

factory-droid bot Mar 23, 2026

Choose a reason for hiding this comment

Footnotes

Uh oh!

factory-droid bot Mar 23, 2026

Choose a reason for hiding this comment

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Mar 23, 2026 •

edited

Loading

`.droid.yaml` to Configure Review Droid