fix(TextInput): Omit role and remove tabindex so both are handled natively#1108
Merged
ykelkar-eightfold merged 4 commits intoEightfoldAI:mainfrom Mar 23, 2026
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ykelkar-eightfold
force-pushed
the
ykelkar/a11y-follow-up
branch
from
d05a188 to
b472436
Compare
kheinrich-eightfold
approved these changes
Mar 23, 2026
Contributor
kheinrich-eightfold
left a comment
kheinrich-eightfold
left a comment
There was a problem hiding this comment.
LGTM overall, see minor feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Omit
roleand removetabindexso both are handled natively. It is redundant to set role andtabindexsince<input>will handle them out of the box. If the<input>is oftype=number, thenrole="spinbutton"will be applied. Otherwise,role="textbox"will be applied.GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-163013
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Observe that role and tabindex are not seen in the html, but role is set properly in the Accessibility tab:
Default
Type Number
Verified in PCSX as well (after removing explicit setting of role):
