Conversation
Owner
Author
|
Hello, Lee. I tried to store the key but didn't have enough time. Also I could separate drinks, unfortunately, Coffee API isn't working today. |
Lee-Rice
reviewed
Sep 26, 2024
Lee-Rice
left a comment
Lee-Rice
left a comment
There was a problem hiding this comment.
Hi Elena,
Here are my comments on your open-api project. I'll also send them through Slack.
- Great job overall. This is really cool project and must have been a ton of work. The only real issue I noticed was that the
Closebutton on the last page (under the dog's picture) throws an errorcloseForm is not defined. - No worries about the API. It looks like you're catching and logging error messages. It wouldn't be a bad idea to let the user know an error occurred as well though, just so they aren't confused why no drinks are showing.
- Outstanding work on the
READMEfile. Especially explaining to the user how to replace the API key with one of their own. - I really like how you added the "Meet" box that pops up with information about each dog.
- On some pages, the Top button covers the Next button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added gifts page and media queries, created session storage, worked on styles