Add autocomplete component#3
Draft
AnnaAlekhina wants to merge 31 commits into
Draft
Conversation
AnnaAlekhina
changed the title
AnnaAlekhina
force-pushed
the
feature/1-autocomplete
branch
from
4554ff5 to
ef09eea
Compare
evseevdev
reviewed
Feb 3, 2020
evseevdev
reviewed
Feb 3, 2020
| public get disabled(): boolean { | ||
| return this._disabled; | ||
| } | ||
| public set disabled(dis: boolean) { |
Contributor
There was a problem hiding this comment.
В принципе аргумент можно называть value везде. Кажется, так будет понятнее.
evseevdev
reviewed
Feb 3, 2020
| * Function that maps an option control value to its display value in the trigger | ||
| */ | ||
| @Input() public displayWith = (value?: any): string | undefined => { | ||
| return value ? value : undefined; |
Contributor
There was a problem hiding this comment.
Нужна ли здесь проверка? Почему бы просто не вернуть value? Вдруг это false
evseevdev
reviewed
Feb 3, 2020
evseevdev
reviewed
Feb 3, 2020
feerzlay
force-pushed
the
feature/1-autocomplete
branch
from
4303729 to
993e042
Compare
feerzlay
force-pushed
the
feature/1-autocomplete
branch
from
993e042 to
24e5ac0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.