Skip to content

DANFSE: corrige erro de conversão float quando pis/cofins vazios#159

Merged
antoniospneto merged 2 commits into
mainfrom
fix/danfse-pis-cofins-float
May 27, 2026
Merged

DANFSE: corrige erro de conversão float quando pis/cofins vazios#159
antoniospneto merged 2 commits into
mainfrom
fix/danfse-pis-cofins-float

Conversation

@antoniospneto
Copy link
Copy Markdown
Contributor

Resumo

Corrige ValueError: could not convert string to float: '' ao gerar DANFSe quando o elemento <piscofins> existe no XML mas as tags <vPis> e <vCofins> estão ausentes.

Substitui a #158 com:

  • Fix mais enxuto (float(pis or 0) + float(cofins or 0)), sem helper novo nem try/except redundante
  • Apenas os 2 PDFs afetados pela mudança de fixture foram regerados (os *_hom.pdf ficam intactos, já que a fixture de homologação não muda)
  • PDFs regerados em ambiente alinhado ao CI (fpdf2 2.8.7, Pillow 12.2.0, fonttools 4.63.0)

Fecha #158.

Co-authored-by: @leogregianin

Test plan

  • pytest tests/test_danfse.py passa localmente com qpdf instalado (mesma comparação do CI)
  • Suite completa passa (58 testes, ignorando test_cli.py por dep ausente local)
  • CI verde

Trata o caso em que o elemento piscofins existe no XML mas as tags
vPis e vCofins estão ausentes, evitando ValueError ao gerar o DANFSe.

Co-authored-by: Leonardo Gregianin <leogregianin@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.65%. Comparing base (32e6810) to head (20e994f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   95.49%   95.65%   +0.15%     
==========================================
  Files          32       32              
  Lines        4393     4393              
  Branches      311      311              
==========================================
+ Hits         4195     4202       +7     
+ Misses        131      125       -6     
+ Partials       67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@antoniospneto antoniospneto changed the title danfse: corrige erro de conversão float quando pis/cofins vazios DANFSE: corrige erro de conversão float quando pis/cofins vazios May 27, 2026
@antoniospneto antoniospneto merged commit cc992ea into main May 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant