Fix obtention of rx_bitrate and tx_bitrate.#3
Open
Property404 wants to merge 1 commit into
Open
Conversation
The obtention of the rx/tx bitrates was implemented incorrectly. The obtention was searching for a type of Nl80211StaInfo::StaInfoRxBytes, which is of the wrong enum type, and effectively maps to Nl80211RateInfo::RateInfoMcs, when it should be maping to Nl80211StaInfo::RateInfoBitrate or Nl80211StaInfo::RateInfoBitrate32. The 32-bit bitrate was introduced almost 10 years ago, so I don't believe it's necessary to account for the possibility of it not being there, like `iw` does (see `parse_bitrate()` in `station.c`).
|
FYI I've included this fix in https://github.com/MaxVerevkin/neli-wifi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The obtention of the rx/tx bitrates was implemented incorrectly.
The obtention was searching for a type of
Nl80211StaInfo::StaInfoRxBytes, which is of the wrong enum type, and
effectively maps to Nl80211RateInfo::RateInfoMcs, when it should be
mapping to Nl80211StaInfo::RateInfoBitrate or
Nl80211StaInfo::RateInfoBitrate32.
The 32-bit bitrate was introduced almost 10 years ago, so I don't believe it's
necessary to account for the possibility of it not being there, like
iwdoes (seeparse_bitrate()instation.c).