extractor: fix plugin monkey-patch not taking effect for load_cves_from_sources#17
Merged
Merged
Conversation
Update extra/README.md with separate examples for data enrichment sources and input source plugins. Highlight the requirement that is_enabled() must work purely from parsed args. Assisted-by: Kiro:claude-opus-4.6 Signed-off-by: Daniel Turull <daniel.turull@ericsson.com>
…om_sources __main__.py imported load_cves_from_sources as a direct name binding, so the NDJSON input plugin's replacement on the cve_sources module was never visible at the call site. Import the module instead so the attribute lookup picks up the patched function. Update test mock targets to patch at the function's defining module. Signed-off-by: Daniel Turull <daniel.turull@ericsson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__main__.pyimportedload_cves_from_sourcesas a direct name binding, so the NDJSON input plugin's monkey-patch on thecve_sourcesmodule was never visible at the call site. This caused--cve-ndjsonto produce 0 CVEs.Changes
cve_sourcesmodule in__main__.pyinstead of binding the function directly, so the attribute lookup picks up the patched function at call time.Testing