Replace overall safety task in hotshot integration tests#2586
Merged
Conversation
ss-es
requested review from
ImJeremyHe,
imabdulbasit,
jbearer,
philippecamacho,
sveitser and
tbro
as code owners
bfish713
approved these changes
Feb 14, 2025
Contributor
|
Looks good to go once the merge conflict resolves. Was the problem that some hotshot tests were running parallel? |
Contributor
Author
yeah, I'm going to merge #2620 first as a better fix for that (which should also make CI nicer for hotshot changes). I'll update this PR once that gets in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreation of EspressoSystems/HotShot#4081. See that PR for a description of changes.
Note: this PR additionally reverts some changes to the
hotshot-builder-apiinterface that were introduced in the process of merging HotShot into the sequencer. We're discussing how to deal with those changes separately.