fix logging: include requested height in cert2 not found error#4303
Open
imabdulbasit wants to merge 1 commit into
Open
fix logging: include requested height in cert2 not found error#4303imabdulbasit wants to merge 1 commit into
imabdulbasit wants to merge 1 commit into
Conversation
Contributor
|
Claude finished @imabdulbasit's task in 54s —— View job Review of PR #4303
LGTM — this is a clean, well-scoped improvement. The change adds the
No issues found. Ship it. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the error message in the light client API to include the requested height when a cert2 finality proof is not found, providing more context for the error. I have no feedback to provide as there were no review comments to evaluate.
sveitser
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review: