Open
Conversation
XanderRiga
reviewed
Aug 25, 2020
| Test service that runs against iRacing's server. | ||
| """ | ||
|
|
||
| def setUp(self) -> None: |
Collaborator
There was a problem hiding this comment.
Do we need the client we instantiate above if we re-instantiate here? Should we be using the singleton we created as you mentioned in the comment so we don't auth multiple times when we run more suites?
XanderRiga
reviewed
Aug 25, 2020
|
|
||
|
|
||
| class ClientTest(unittest.TestCase): | ||
| class ClientTest(IRacingIntegrationTest): |
Collaborator
There was a problem hiding this comment.
Do we need to explicitly call the setUp method? Or is that handled implicitly by the tests? I just want to make sure self.client isn't null throughout the tests.
XanderRiga
reviewed
Aug 25, 2020
| on: | ||
| push: | ||
| branches: master | ||
| tags: |
Collaborator
There was a problem hiding this comment.
What was this originally for?
XanderRiga
approved these changes
Aug 25, 2020
Collaborator
XanderRiga
left a comment
XanderRiga
left a comment
There was a problem hiding this comment.
Just a few questions, but looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL YOU UNDERSTAND PERMISSIONS IMPLICATIONS