feat: add TypeScript to utils and code-split heavy components#609
Merged
Mystery-CLI merged 2 commits intoMay 29, 2026
Merged
Conversation
- Add typescript ^5, @types/react ^18.3, @types/react-dom ^18.3 to
frontend devDependencies and a `typecheck` (tsc --noEmit) script
- Add tsconfig.json with strict mode, allowJs/checkJs:false for
incremental migration; moduleResolution: bundler for Vite compat
- Convert all 8 src/utils/ files from .js → .ts with full types:
interfaces for ApiError, Transaction, SearchCriteria, ErrorEntry,
VitalEntry, AnimationVariants; declare global Window extensions
- Add tsc --noEmit step to CI workflow (.github/workflows/test.yml)
- Convert AMMPoolBrowser, AccountRecovery, MultiSigTransactions,
KYCForm, ComplianceDashboard, BackupSettings to React.lazy() in
App.jsx; wrap each render site in <Suspense fallback={<Spinner />}>
- Add lazy-loading.test.js asserting no static imports exist for
heavy components and lazy() declarations are present
- Add frontend/docs/typescript-migration.md with 8-phase plan for
migrating remaining .jsx files to .tsx
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@Markodiba Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typecheck(tsc --noEmit) scriptcloses #467
closes #468