feat: VirtualList, offline indicator, structured logging, Prometheus metrics (#491–#494)#623
Merged
Conversation
… metrics Closes Ethereal-Future#491 — Integrates VirtualList (@tanstack/react-virtual) into TransactionHistory.jsx, replacing the plain DOM render loop with a windowed list capped at 480px so large transaction sets stay at 60fps. Closes Ethereal-Future#492 — Adds OfflineIndicator component (listens to browser online/offline events) rendered at the app root; SW already implements cache-first for static assets and network-first for API calls with background sync replay. Closes Ethereal-Future#493 — Exports withContext(logger, ctx) from logger.js creating a child logger pre-bound with { correlationId, userId, action, durationMs }; applied to key log calls in stellar.js, streaming.js, and transactions.js. Closes Ethereal-Future#494 — Adds business counters (payments_total, payments_failed_total, accounts_created_total), gauges (active_streams, pending_multisig_transactions), and histograms (payment_amount_xlm, stellar_api_duration_seconds) to metrics.js; GET /api/metrics now returns Prometheus text format when Accept: text/plain; adds docs/grafana-dashboard.json reference dashboard. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@victorisiguzoruzoma874 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VirtualList(backed by@tanstack/react-virtual) intoTransactionHistory.jsx; the plain DOM loop is replaced with a windowed list capped at 480 px, rendering only visible rows so large transaction sets stay smooth.OfflineIndicatorcomponent that listens to browseronline/offlineevents and displays a fixed toast when the user loses connectivity; the service worker already implements cache-first for static assets, network-first for API calls, and background-sync replay of queued payments.withContext(logger, ctx)fromlogger.js(thin wrapper over Winston'slogger.child(ctx)); applies it with the standard{ correlationId, userId, action, durationMs }shape to key log calls instellar.js,streaming.js, andtransactions.js.payments_total,payments_failed_total,accounts_created_total), gauges (active_streams,pending_multisig_transactions), and histograms (payment_amount_xlm,stellar_api_duration_seconds) tometrics.js;GET /api/metricsnow returns Prometheus text format whenAccept: text/plain; addsdocs/grafana-dashboard.jsonreference dashboard covering all new KPIs.Closes
Closes #491
Closes #492
Closes #493
Closes #494
🤖 Generated with Claude Code