Add destructive migration option for oversized strokes #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces an optional "Allow destructive migrations" setting to handle `SQLiteBlobTooBigException` errors during stroke data re-encoding. --AI-- When this setting is enabled, if a stroke is too large to be migrated even with a batch size of 1, it will be deleted to allow the migration to proceed. If disabled (the default), the migration will halt, and a message will be displayed prompting the user to enable the option in the Debug Settings. - Added `destructiveMigrations` flag to `AppSettings`. - Implemented logic in `StrokeReencoding` to delete oversized rows when the flag is set. - Added a toggle for this option in the Debug Settings UI.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a user-controllable “Allow destructive migrations” setting to handle SQLiteBlobTooBigException during the runtime stroke re-encoding/backfill, with a fallback that can delete oversized legacy rows when enabled.
Changes:
- Introduces
destructiveMigrationsinAppSettingsand surfaces it as a toggle in Debug Settings. - Updates stroke re-encoding migration logic to optionally delete oversized
stroke_oldrows when batch size reduction can’t proceed. - Adds delayed snackbar emission helper and additional migration logging/snack messages.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| app/src/main/java/com/ethran/notable/ui/views/Settings.kt | Adds Debug Settings toggle for destructive migrations. |
| app/src/main/java/com/ethran/notable/ui/SnackBar.kt | Adds a coroutine import (currently unused). |
| app/src/main/java/com/ethran/notable/data/db/StrokeReencoding.kt | Implements destructive fallback behavior + helper functions for snackbar emission and deletion. |
| app/src/main/java/com/ethran/notable/data/datastore/AppSettings.kt | Adds destructiveMigrations setting to persisted app settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import kotlinx.coroutines.CoroutineScope | ||
| import kotlinx.coroutines.Dispatchers | ||
| import kotlinx.coroutines.NonCancellable | ||
| import kotlinx.coroutines.channels.BufferOverflow |
There was a problem hiding this comment.
BufferOverflow is imported but not used anywhere in this file; Kotlin treats unused imports as a compile error. Remove the import or update the code to use it (e.g., configure MutableSharedFlow(..., onBufferOverflow = ...)).
Suggested change
| import kotlinx.coroutines.channels.BufferOverflow |
app/src/main/java/com/ethran/notable/data/db/StrokeReencoding.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/ethran/notable/data/db/StrokeReencoding.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an optional "Allow destructive migrations" setting to handle
SQLiteBlobTooBigExceptionerrors during stroke data re-encoding.