fix(docker): replace grunt with build-pipeline.js in web-apps Dockerfile#150
Merged
Conversation
build/sprites/ and build/Gruntfile.js were removed by the webpack migration. The Dockerfile was not updated and referenced both, breaking all Docker builds after the merge of the webpack migration PR. - Remove COPY of build/sprites/package*.json (directory deleted) - Remove COPY of build/plugins/grunt-inline/ (grunt's inline step, now handled by inline-svgs.js via build-pipeline.js) - Remove grunt-cli from global npm install (no Gruntfile to run) - Replace `grunt` RUN with `node scripts/build-pipeline.js` Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
moodyjmz
requested review from
MonaAghili and
rikled
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build/sprites/andbuild/plugins/grunt-inline/— both deleted by the webpack migration (build: replace Grunt+r.js with webpack 5 — Phase E complete #109)grunt-clifrom the base image global install — no Gruntfile to rungruntRUN step withnode scripts/build-pipeline.js, matching what CI now doesRoot cause
PR #109 (webpack migration) deleted
build/Gruntfile.jsandbuild/sprites/but did not update.docker/web-apps.bake.Dockerfile. The Docker build failed immediately on theCOPY web-apps/build/sprites/package*.jsonline because that directory no longer exists.Test plan
docker-bake) succeeds with updated web-apps pointer🤖 Generated with Claude Code