37 seat layout generation overlapping issue#39
Merged
Conversation
…ting components for improved layout handling
…esizable components
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how seating layouts are rendered and managed across several components in the app. The main improvement is the introduction of the
normalizeSeatingLayoututility, which standardizes block dimensions and layout calculations. This change ensures consistent sizing and positioning of seating blocks, improves layout rendering, and reduces duplicated logic. The update also applies more robust handling of block types and minimum canvas heights for better UI consistency.Seating Layout Normalization and Rendering Improvements:
normalizeSeatingLayoututility to standardize block dimensions and layout calculations for seating maps, replacing custom height calculations and direct block usage inSeatingLayout,SeatingLayoutPreview, and related components. (src/app/(home-app)/events/[event_id]/[session_id]/_components/SeatingLayout.tsxR3-L7, src/app/(home-app)/events/[event_id]/_components/SeatingLayoutPreview.tsxR3-R32, src/app/manage/_components/review/SeatingLayout.tsxR8, src/app/manage/organization/[organization_id]/event/_components/TierAssignmentEditor.tsxR7)SeatingLayout,TierAssignmentEditor,InteractiveBlocks) to use normalized dimensions, improving consistency for draggable and resizable blocks. (src/app/manage/_components/review/SeatingLayout.tsxL17-R69, src/app/manage/organization/[organization_id]/event/_components/InteractiveBlocks.tsxR24-R31, src/app/manage/organization/[organization_id]/event/_components/InteractiveBlocks.tsxR108-R114, src/app/manage/organization/[organization_id]/event/_components/TierAssignmentEditor.tsxR21-R24)Code Consistency and Readability:
Type and Data Handling Improvements:
paramsand improved type safety for parameter extraction. (src/app/(home-app)/events/[event_id]/layout.tsxR14-R20)