Solves for issue #6 by adding path string to the context object used …#7
Open
dbolack-ab wants to merge 4 commits intoEvolveLabs:masterfrom
Open
Solves for issue #6 by adding path string to the context object used …#7dbolack-ab wants to merge 4 commits intoEvolveLabs:masterfrom
dbolack-ab wants to merge 4 commits intoEvolveLabs:masterfrom
Conversation
…ject used on load. Also adds two booleans. One to create the plugin path if not found and another to quiet console messages. If the provided app path is empty, the default will be used. If the first character of the path is ~, that will be substitued with the results of os.homedir() If the last character of the path is :, that will be sibstituted with the App Path per ApplicationPath Both substitutions are performed with path.join. README.md updated to match.
… return either the highest installed version or the LINK version based on a passed boolean.
Added plugins attribute to the context object allowing the user to provide an object of plugins from another settings store or the discovery function. Object format should match the { pluginname: version, ...} attribute scheme already used.
Did a little linty clean up.
Updated README.md to hopefully explain these changes.
Added compare-versions depend for semvar comparisons.
Reworked a little bit of shared code into common helper functions ( substitutePluginPath )
discover function does NOT load, only finds.
Contributor
|
Hey, thanks for the PR! I'm the original author of this package and as such am willing to merge this change and publish it but I have been out of the loop with the evolve team and would like to hear any feedback they may have on these changes before doing so. @BlairEvolve I'm not sure if this library still affects the client or not but I'm happy to help transfer npm module ownership or just publish changes as needed. |
This allows you to load plugins from teh main thread instead of a renderer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on load.
Also adds two booleans. One to create the plugin path if not found and another to quiet console messages.
If the provided app path is empty, the default will be used.
If the first character of the path is ~, that will be substitued with the results of os.homedir()
If the last character of the path is :, that will be sibstituted with the App Path per ApplicationPath
Both substitutions are performed with path.join.
README.md updated to match.