Skip to content

Comments

update: add properties enum (claude)#40

Open
VsevolodX wants to merge 9 commits intomainfrom
feature/SOF-7824
Open

update: add properties enum (claude)#40
VsevolodX wants to merge 9 commits intomainfrom
feature/SOF-7824

Conversation

@VsevolodX
Copy link
Member

No description provided.

@VsevolodX VsevolodX marked this pull request as ready for review February 18, 2026 17:16
object = "object"


class PropertyName(str, Enum):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not available from ESSE?

Second - we should categorize the properties instead of a just flat list

def get_length(vec: np.ndarray) -> float:
return float(np.linalg.norm(vec))
class ExternalSource(str, Enum):
materials_project = "MaterialsProject"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this we also have MPLegacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants