DKIM: if one of signatures are correct for dkim domain, then use it.#48
Open
BHYCHIK wants to merge 1 commit intoExim:masterfrom
Open
DKIM: if one of signatures are correct for dkim domain, then use it.#48BHYCHIK wants to merge 1 commit intoExim:masterfrom
BHYCHIK wants to merge 1 commit intoExim:masterfrom
Conversation
…not the first one
|
Currently first signature is always used. In situation where message has both valid and invalid DKIM signatures for the same domain (e.g. message is sent to mailing list or signed by forwarder) it may lead to the situation where valid DKIM signature is ignored and message is treated as unsigned. Valid DKIM signature should always be preffered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DKIM: if one of signatures are correct for dkim domain, then use it, not the first one.