Escape quotation marks when logging SMTP strings#88
Open
nomis wants to merge 1 commit intoExim:masterfrom
Open
Escape quotation marks when logging SMTP strings#88nomis wants to merge 1 commit intoExim:masterfrom
nomis wants to merge 1 commit intoExim:masterfrom
Conversation
The SMTP command buffer and various other messages logged inside smtp_in.c
are wrapped in quotes. If the content contains quotes it becomes very
difficult to parse the log correctly because the quoted section can be
ended prematurely.
This happens if someone sends JSON to Exim (attempting to exploit a
non-SMTP service) with a string like:
{"hello": ["world"]}
The distinguished name and possibly other externally supplied strings
enclosed in quotes could also contain quotes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SMTP command buffer and various other messages logged inside
smtp_in.care wrapped in quotes. If the content contains quotes it becomes very difficult to parse the log correctly because the quoted section can be ended prematurely.This happens if someone sends JSON to Exim (attempting to exploit a non-SMTP service) with a string like:
The distinguished name and possibly other externally supplied strings enclosed in quotes could also contain quotes.