Update exim_lock.c Enhance Security with strncpy#96
Open
Shivam7-1 wants to merge 1 commit intoExim:masterfrom
Open
Update exim_lock.c Enhance Security with strncpy#96Shivam7-1 wants to merge 1 commit intoExim:masterfrom
Shivam7-1 wants to merge 1 commit intoExim:masterfrom
Conversation
Collaborator
|
A quick check with the man page of strncpy ... it has 3 arguments : char *strncpy(char dst[restrict .dsize], const char *restrict src, size_t dsize); I'm wondering what the none-optional third one does ... |
Collaborator
|
Just for education: strncpy(), even if used correctly, which you didn't, would not enhance security, because the buffersize check is right infront of that strcpy() call : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR replaces instances of strcpy() with strncpy() to mitigate the risk of buffer overflows. strncpy() ensures safer handling of strings by limiting the number of copied characters and adding null-termination, enhancing the overall security and stability of the code.