Conversation
On 32-bit platforms, len(range(first_elt, last_elt+sign, step)) overflows Py_ssize_t when the bitmap spans values near 2**31-1 (e.g. BitMap([0, 2**31-1])). Replace with abs(last_elt - first_elt) + 1, which is pure Python int arithmetic and cannot overflow. Apply the same fix to AbstractBitMap64._get_slice, where the same overflow would occur on any platform for bitmaps spanning [0, 2**63-1]. Also restore pytest test.py in the wheel build CI (dropped in fd5bd43).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 32-bit platforms,
len(range(first_elt, last_elt+sign, step))overflowsPy_ssize_twhen the bitmap spans values near2**31-1(e.g.BitMap([0, 2**31-1])). Replace withabs(last_elt - first_elt) + 1, which is pure Python int arithmetic and cannot overflow. Apply the same fix toAbstractBitMap64._get_slice, where the same overflow would occur on any platform for bitmaps spanning[0, 2**63-1].Also restore pytest test.py in the wheel build CI (dropped in fd5bd43).