Added Faceswapping#378
Open
hadxp wants to merge 2 commits into
Open
Conversation
Member
|
Thanks for this, definitely going to take me a minute to read through it all but I appreciate it. |
Member
|
So I have ethical concerns about including this generally and also some concerns about how it could impact github's feelings about the project. But I also have technical concerns. You seem to have included a ton of code that's never used in this context. The entire CodeFormer/basicsr training framework seems to be included and most isn't needed. I'm going to pass on this for now, if you want to update the implementation I may reconsider. I can see legitimate uses for it but the 'other' uses still concern me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added faceswapping for generated videos in output tab