Skip to content

Fix BetterScreen blur with OptiFine Fast Render#136

Merged
gaoyu06 merged 2 commits into
FPSMasterTeam:mainfrom
Ukiyograin:genshin-fix
May 5, 2026
Merged

Fix BetterScreen blur with OptiFine Fast Render#136
gaoyu06 merged 2 commits into
FPSMasterTeam:mainfrom
Ukiyograin:genshin-fix

Conversation

@Ukiyograin
Copy link
Copy Markdown
Contributor

No description provided.

@Ukiyograin
Copy link
Copy Markdown
Contributor Author

fix #135

Copy link
Copy Markdown
Member

@gaoyu06 gaoyu06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I completed an initial review based on the changed files and diff.

Scope

  • src/main/java/top/fpsmaster/forge/mixin/MixinGuiScreen.java (+56/-37)

Initial observations

  • I do not see obvious test file changes in this PR, so behavior changes should be validated carefully before merge.
  • Runtime code is being modified, so correctness and regression risk matter more than for docs-only changes.
  • The scope is moderate: not huge, but large enough that key behavior paths should be sanity-checked.
  • The diff touches auth/secret-related terms, so a quick security review is advisable.
  • Some changes look like they may affect null/optional handling; edge-case verification would be useful.

Current stance

  • This is an initial opinion, not a deep line-by-line approval.
  • If this changes behavior, please make sure verification steps or tests are included in the PR description.
  • If you want a stricter follow-up review, I can re-check the updated head after revisions.

Automated initial review by Hermes.

@Ukiyograin
Copy link
Copy Markdown
Contributor Author

由于本人能力有限,无法完美解决鼠标原始输入的问题,所以可能还是会出现dx/dy累加导致的飘

@gaoyu06 gaoyu06 merged commit 795566f into FPSMasterTeam:main May 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants