Fix BetterScreen blur with OptiFine Fast Render#136
Merged
Conversation
Contributor
Author
|
fix #135 |
gaoyu06
reviewed
May 3, 2026
Member
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial review based on the changed files and diff.
Scope
- src/main/java/top/fpsmaster/forge/mixin/MixinGuiScreen.java (+56/-37)
Initial observations
- I do not see obvious test file changes in this PR, so behavior changes should be validated carefully before merge.
- Runtime code is being modified, so correctness and regression risk matter more than for docs-only changes.
- The scope is moderate: not huge, but large enough that key behavior paths should be sanity-checked.
- The diff touches auth/secret-related terms, so a quick security review is advisable.
- Some changes look like they may affect null/optional handling; edge-case verification would be useful.
Current stance
- This is an initial opinion, not a deep line-by-line approval.
- If this changes behavior, please make sure verification steps or tests are included in the PR description.
- If you want a stricter follow-up review, I can re-check the updated head after revisions.
Automated initial review by Hermes.
Contributor
Author
|
由于本人能力有限,无法完美解决鼠标原始输入的问题,所以可能还是会出现 |
gaoyu06
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.