Search all APP2 sections for ICC profile data#21
Open
ColdPie1 wants to merge 1 commit intoFileEye:masterfrom
Open
Search all APP2 sections for ICC profile data#21ColdPie1 wants to merge 1 commit intoFileEye:masterfrom
ColdPie1 wants to merge 1 commit intoFileEye:masterfrom
Conversation
Apple phones often include several images in one file using the Multi-Picture Format standard. This is implemented via a MPF0 object within an APP2 section. Pel should search for the ICC section instead of returning the first APP2 section.
Author
|
Worth a note that this adds a call to |
|
Thank you, can you add an automated test for this, including a test image? |
Author
|
I put a test image on issue #20 . I can try to write a test some time, but I'm not familiar with the test framework. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #20 .
Apple phones often include several images in one file using the Multi-Picture Format standard. This is implemented via a MPF0 object within an APP2 section. Pel should search for the ICC section instead of returning the first APP2 section.