Skip to content

Add com.tivadar.best.socketio to embedded package build steps across all platforms #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyfios merged 2 commits into from
Apr 6, 2026
Merged

Add com.tivadar.best.socketio to embedded package build steps across all platforms #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
043af00
Initial plan
Copilot Apr 6, 2026
a6604f3
Add com.tivadar.best.socketio to all build workflow embedded package …
Copilot Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions .github/workflows/build-runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ jobs:
run: |
$packagesPath = "$env:UNITY_PACKAGES_PATH"
if (-not (Test-Path $packagesPath)) { Write-Host "::error::Packages not found"; exit 1 }
$embeddedPackages = @("com.occasoftware.super-simple-skybox", "com.tivadar.best.http", "com.tivadar.best.mqtt", "com.tivadar.best.websockets")
$embeddedPackages = @("com.occasoftware.super-simple-skybox", "com.tivadar.best.http", "com.tivadar.best.mqtt", "com.tivadar.best.websockets", "com.tivadar.best.socketio")
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The embedded package list is duplicated across multiple jobs in this workflow (Windows/WebGL/Android PowerShell + Mac/iOS bash). Since this PR is fixing an omission caused by that duplication, consider centralizing the package list (e.g., YAML anchor or a single env var) so future package additions only need to be made in one place.

Copilot uses AI. Check for mistakes.
foreach ($pkg in $embeddedPackages) {
$sourcePath = Join-Path $packagesPath $pkg
$targetPath = Join-Path "$env:PROJECT_PATH\Packages" $pkg
Expand Down Expand Up @@ -267,6 +267,7 @@ jobs:
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.http" -Recurse -Force -ErrorAction SilentlyContinue
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.mqtt" -Recurse -Force -ErrorAction SilentlyContinue
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.websockets" -Recurse -Force -ErrorAction SilentlyContinue
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.socketio" -Recurse -Force -ErrorAction SilentlyContinue

# WebGL Compressed build (runs after Windows Desktop to benefit from Library cache)
build-webgl-compressed:
Expand Down Expand Up @@ -352,7 +353,7 @@ jobs:
shell: powershell -ExecutionPolicy Bypass {0}
run: |
$packagesPath = "$env:UNITY_PACKAGES_PATH"
$embeddedPackages = @("com.occasoftware.super-simple-skybox", "com.tivadar.best.http", "com.tivadar.best.mqtt", "com.tivadar.best.websockets")
$embeddedPackages = @("com.occasoftware.super-simple-skybox", "com.tivadar.best.http", "com.tivadar.best.mqtt", "com.tivadar.best.websockets", "com.tivadar.best.socketio")
foreach ($pkg in $embeddedPackages) {
$sourcePath = Join-Path $packagesPath $pkg
$targetPath = Join-Path "$env:PROJECT_PATH\Packages" $pkg
Expand Down Expand Up @@ -448,6 +449,7 @@ jobs:
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.http" -Recurse -Force -ErrorAction SilentlyContinue
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.mqtt" -Recurse -Force -ErrorAction SilentlyContinue
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.websockets" -Recurse -Force -ErrorAction SilentlyContinue
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.socketio" -Recurse -Force -ErrorAction SilentlyContinue

# WebGL Uncompressed build (runs after WebGL Compressed)
build-webgl-uncompressed:
Expand Down Expand Up @@ -533,7 +535,7 @@ jobs:
shell: powershell -ExecutionPolicy Bypass {0}
run: |
$packagesPath = "$env:UNITY_PACKAGES_PATH"
$embeddedPackages = @("com.occasoftware.super-simple-skybox", "com.tivadar.best.http", "com.tivadar.best.mqtt", "com.tivadar.best.websockets")
$embeddedPackages = @("com.occasoftware.super-simple-skybox", "com.tivadar.best.http", "com.tivadar.best.mqtt", "com.tivadar.best.websockets", "com.tivadar.best.socketio")
foreach ($pkg in $embeddedPackages) {
$sourcePath = Join-Path $packagesPath $pkg
$targetPath = Join-Path "$env:PROJECT_PATH\Packages" $pkg
Expand Down Expand Up @@ -629,6 +631,7 @@ jobs:
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.http" -Recurse -Force -ErrorAction SilentlyContinue
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.mqtt" -Recurse -Force -ErrorAction SilentlyContinue
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.websockets" -Recurse -Force -ErrorAction SilentlyContinue
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.socketio" -Recurse -Force -ErrorAction SilentlyContinue

# Mac Desktop build (runs in parallel with Windows jobs)
build-mac:
Expand Down Expand Up @@ -694,7 +697,7 @@ jobs:
- name: Setup Unity packages (Embedded)
run: |
PACKAGES_PATH="$UNITY_PACKAGES_PATH"
for pkg in "com.occasoftware.super-simple-skybox" "com.tivadar.best.http" "com.tivadar.best.mqtt" "com.tivadar.best.websockets"; do
for pkg in "com.occasoftware.super-simple-skybox" "com.tivadar.best.http" "com.tivadar.best.mqtt" "com.tivadar.best.websockets" "com.tivadar.best.socketio"; do
source_path="$PACKAGES_PATH/$pkg"
target_path="$PROJECT_PATH/Packages/$pkg"
if [ -d "$source_path" ]; then
Expand Down Expand Up @@ -775,7 +778,7 @@ jobs:
rm -rf "$PROJECT_PATH/Assets/Runtime/StraightFour/3rd-party/Silantro" "$PROJECT_PATH/Assets/Runtime/StraightFour/3rd-party/Silantro.meta" || true
rm -rf "$PROJECT_PATH/Assets/Runtime/StraightFour/3rd-party/URPWater" "$PROJECT_PATH/Assets/Runtime/StraightFour/3rd-party/URPWater.meta" || true
rm -rf "$PROJECT_PATH/Assets/Runtime/StraightFour/3rd-party/Vuplex" "$PROJECT_PATH/Assets/Runtime/StraightFour/3rd-party/Vuplex.meta" || true
rm -rf "$PROJECT_PATH/Packages/com.occasoftware.super-simple-skybox" "$PROJECT_PATH/Packages/com.tivadar.best.http" "$PROJECT_PATH/Packages/com.tivadar.best.mqtt" "$PROJECT_PATH/Packages/com.tivadar.best.websockets" || true
rm -rf "$PROJECT_PATH/Packages/com.occasoftware.super-simple-skybox" "$PROJECT_PATH/Packages/com.tivadar.best.http" "$PROJECT_PATH/Packages/com.tivadar.best.mqtt" "$PROJECT_PATH/Packages/com.tivadar.best.websockets" "$PROJECT_PATH/Packages/com.tivadar.best.socketio" || true

# iOS build (runs on Mac runner)
build-ios:
Expand Down Expand Up @@ -841,7 +844,7 @@ jobs:
- name: Setup Unity packages (Embedded)
run: |
PACKAGES_PATH="$UNITY_PACKAGES_PATH"
for pkg in "com.occasoftware.super-simple-skybox" "com.tivadar.best.http" "com.tivadar.best.mqtt" "com.tivadar.best.websockets"; do
for pkg in "com.occasoftware.super-simple-skybox" "com.tivadar.best.http" "com.tivadar.best.mqtt" "com.tivadar.best.websockets" "com.tivadar.best.socketio"; do
source_path="$PACKAGES_PATH/$pkg"
target_path="$PROJECT_PATH/Packages/$pkg"
if [ -d "$source_path" ]; then
Expand Down Expand Up @@ -1031,7 +1034,7 @@ jobs:
rm -rf "$PROJECT_PATH/Assets/Runtime/StraightFour/3rd-party/Silantro" "$PROJECT_PATH/Assets/Runtime/StraightFour/3rd-party/Silantro.meta" || true
rm -rf "$PROJECT_PATH/Assets/Runtime/StraightFour/3rd-party/URPWater" "$PROJECT_PATH/Assets/Runtime/StraightFour/3rd-party/URPWater.meta" || true
rm -rf "$PROJECT_PATH/Assets/Runtime/StraightFour/3rd-party/Vuplex" "$PROJECT_PATH/Assets/Runtime/StraightFour/3rd-party/Vuplex.meta" || true
rm -rf "$PROJECT_PATH/Packages/com.occasoftware.super-simple-skybox" "$PROJECT_PATH/Packages/com.tivadar.best.http" "$PROJECT_PATH/Packages/com.tivadar.best.mqtt" "$PROJECT_PATH/Packages/com.tivadar.best.websockets" || true
rm -rf "$PROJECT_PATH/Packages/com.occasoftware.super-simple-skybox" "$PROJECT_PATH/Packages/com.tivadar.best.http" "$PROJECT_PATH/Packages/com.tivadar.best.mqtt" "$PROJECT_PATH/Packages/com.tivadar.best.websockets" "$PROJECT_PATH/Packages/com.tivadar.best.socketio" || true

# Android build (runs on Windows runner)
build-android:
Expand Down Expand Up @@ -1118,7 +1121,7 @@ jobs:
shell: powershell -ExecutionPolicy Bypass {0}
run: |
$packagesPath = "$env:UNITY_PACKAGES_PATH"
$embeddedPackages = @("com.occasoftware.super-simple-skybox", "com.tivadar.best.http", "com.tivadar.best.mqtt", "com.tivadar.best.websockets")
$embeddedPackages = @("com.occasoftware.super-simple-skybox", "com.tivadar.best.http", "com.tivadar.best.mqtt", "com.tivadar.best.websockets", "com.tivadar.best.socketio")
foreach ($pkg in $embeddedPackages) {
$sourcePath = Join-Path $packagesPath $pkg
$targetPath = Join-Path "$env:PROJECT_PATH\Packages" $pkg
Expand Down Expand Up @@ -1283,6 +1286,7 @@ jobs:
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.http" -Recurse -Force -ErrorAction SilentlyContinue
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.mqtt" -Recurse -Force -ErrorAction SilentlyContinue
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.websockets" -Recurse -Force -ErrorAction SilentlyContinue
Remove-Item -Path "$env:PROJECT_PATH\Packages\com.tivadar.best.socketio" -Recurse -Force -ErrorAction SilentlyContinue

# Summary job
summary:
Expand Down
Loading