Skip to content

OD-174 [Feature] Now users will see the default template at once when they put a new form to the app.#320

Open
YaroslavOvdii wants to merge 1 commit into
Fliplet:masterfrom
YaroslavOvdii:without-templates
Open

OD-174 [Feature] Now users will see the default template at once when they put a new form to the app.#320
YaroslavOvdii wants to merge 1 commit into
Fliplet:masterfrom
YaroslavOvdii:without-templates

Conversation

@YaroslavOvdii

@YaroslavOvdii YaroslavOvdii commented Jul 27, 2020

Copy link
Copy Markdown
Contributor

@sofiiakvasnevska

Issue

https://github.com/Fliplet/fliplet-studio/issues/6740
https://weboo.atlassian.net/browse/OD-174

Description

Now users will see the default template at once when they put a new form to the app.

Screenshots/screencasts

https://share.getcloudapp.com/bLuR1GDY

Backward compatibility

This change is fully backward compatible.

Reviewers

@upplabs-alex-levchenko

@tonytlwu

Copy link
Copy Markdown
Contributor

@sofiiakvasnevska @squallstar We should confirm what's going to happen with organisation form templates first before reviewing this.

@squallstar

Copy link
Copy Markdown
Contributor

@tonytlwu agreed, I see that you already went forward on asking for confirmation to CS and Ian in the ticket so I'll wait until they come back to us before reviewing this.

@sofiiakvasnevska sofiiakvasnevska changed the title [Feature] Now users will see the default template at once when they put a new form to the app. OD-174 [Feature] Now users will see the default template at once when they put a new form to the app. Oct 7, 2020
@sofiiakvasnevska

Copy link
Copy Markdown
Contributor

@squallstar Ian has **confirmed** could you please review the PR

@squallstar

squallstar commented Oct 7, 2020

Copy link
Copy Markdown
Contributor

@sofiiakvasnevska @YaroslavOvdii what about organizations that have already defined form templates and are actively using them? Will the current change keep the existing behaviour and display the template selection?

cc @tonytlwu

Note that this is outlined in the original ticket as a requirement in the comments.

@tonytlwu

tonytlwu commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

@sofiiakvasnevska The confirmation suggests that if organisation form templates are available, users should have the ability to choose an organisation form templates first.

This PR shows the template selection UI being removed entirely, in contrary to the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants