Bump version: 0.1.1 → 0.1.2#63
Merged
Merged
Conversation
Code Review by Qodo
1. Wrong dist version lookup
|
Comment on lines
11
to
+14
| __version__ = version("mach") | ||
| except PackageNotFoundError: | ||
| # Update via bump-my-version, not manually | ||
| __version__ = "0.1.1" | ||
| __version__ = "0.1.2" |
There was a problem hiding this comment.
1. Wrong dist version lookup 🐞 Bug ≡ Correctness
src/mach/__init__.py calls importlib.metadata.version("mach"), but the distribution name declared in
pyproject.toml is "mach-beamform". In normal installs this will raise PackageNotFoundError and
always use the hardcoded fallback __version__, making metadata-based version reporting unreliable.
Agent Prompt
## Issue description
`src/mach/__init__.py` tries to read the installed package version via `importlib.metadata.version("mach")`, but the distribution name configured for packaging is `mach-beamform`. This mismatch makes the metadata lookup fail and forces the code to always use the hardcoded fallback version.
## Issue Context
- Module name (`mach`) and distribution/project name (`mach-beamform`) can differ; `importlib.metadata.version()` expects the distribution name.
## Fix Focus Areas
- src/mach/__init__.py[11-14]
- pyproject.toml[5-8]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
Code review by qodo was updated up to the latest commit 928b943 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the Github issue, if applicable
Introduction
In the introduction, please describe the type of change introduced by the pull request and its purpose and link the GitHub issue that this pull request addresses if possible, or add any reference that would provide more context to the reviewer.
Changes
Please list the changes introduced by the pull request and the important design decisions that were made.
Behavior
How the new behavior is different from the current behavior, how you tested and how the reviewer can test it.
Review checklist