Skip to content

Bump version: 0.1.1 → 0.1.2#63

Merged
cmcneil merged 1 commit into
mainfrom
bump-0.1.2
Jun 2, 2026
Merged

Bump version: 0.1.1 → 0.1.2#63
cmcneil merged 1 commit into
mainfrom
bump-0.1.2

Conversation

@cmcneil
Copy link
Copy Markdown
Contributor

@cmcneil cmcneil commented Jun 2, 2026

Link to the Github issue, if applicable

Introduction

In the introduction, please describe the type of change introduced by the pull request and its purpose and link the GitHub issue that this pull request addresses if possible, or add any reference that would provide more context to the reviewer.

Changes

Please list the changes introduced by the pull request and the important design decisions that were made.

Behavior

How the new behavior is different from the current behavior, how you tested and how the reviewer can test it.

Review checklist

  • All existing tests and checks pass
  • Unit tests covering the new feature or bugfix have been added
  • The documentation has been updated if necessary

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented Jun 2, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Action required

1. Wrong dist version lookup 🐞 Bug ≡ Correctness
Description
src/mach/__init__.py calls importlib.metadata.version("mach"), but the distribution name declared in
pyproject.toml is "mach-beamform". In normal installs this will raise PackageNotFoundError and
always use the hardcoded fallback __version__, making metadata-based version reporting unreliable.
Code

src/mach/init.py[R11-14]

Evidence
The project declares the distribution name as "mach-beamform", but the code queries metadata for
"mach", so the lookup will not find the installed distribution and will fall back to the constant.

pyproject.toml[5-8]
src/mach/init.py[8-15]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`src/mach/__init__.py` tries to read the installed package version via `importlib.metadata.version("mach")`, but the distribution name configured for packaging is `mach-beamform`. This mismatch makes the metadata lookup fail and forces the code to always use the hardcoded fallback version.
## Issue Context
- Module name (`mach`) and distribution/project name (`mach-beamform`) can differ; `importlib.metadata.version()` expects the distribution name.
## Fix Focus Areas
- src/mach/__init__.py[11-14]
- pyproject.toml[5-8]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Previous review results

Review updated until commit 928b943

Results up to commit 928b943


🐞 Bugs (1) 📘 Rule violations (0)


Action required
1. Wrong dist version lookup 🐞 Bug ≡ Correctness
Description
src/mach/__init__.py calls importlib.metadata.version("mach"), but the distribution name declared in
pyproject.toml is "mach-beamform". In normal installs this will raise PackageNotFoundError and
always use the hardcoded fallback __version__, making metadata-based version reporting unreliable.
Code

src/mach/init.py[R11-14]

Evidence
The project declares the distribution name as "mach-beamform", but the code queries metadata for
"mach", so the lookup will not find the installed distribution and will fall back to the constant.

pyproject.toml[5-8]
src/mach/init.py[8-15]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`src/mach/__init__.py` tries to read the installed package version via `importlib.metadata.version("mach")`, but the distribution name configured for packaging is `mach-beamform`. This mismatch makes the metadata lookup fail and forces the code to always use the hardcoded fallback version.

## Issue Context
- Module name (`mach`) and distribution/project name (`mach-beamform`) can differ; `importlib.metadata.version()` expects the distribution name.

## Fix Focus Areas
- src/mach/__init__.py[11-14]
- pyproject.toml[5-8]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Qodo Logo

Comment thread src/mach/__init__.py
Comment on lines 11 to +14
__version__ = version("mach")
except PackageNotFoundError:
# Update via bump-my-version, not manually
__version__ = "0.1.1"
__version__ = "0.1.2"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Wrong dist version lookup 🐞 Bug ≡ Correctness

src/mach/__init__.py calls importlib.metadata.version("mach"), but the distribution name declared in
pyproject.toml is "mach-beamform". In normal installs this will raise PackageNotFoundError and
always use the hardcoded fallback __version__, making metadata-based version reporting unreliable.
Agent Prompt
## Issue description
`src/mach/__init__.py` tries to read the installed package version via `importlib.metadata.version("mach")`, but the distribution name configured for packaging is `mach-beamform`. This mismatch makes the metadata lookup fail and forces the code to always use the hardcoded fallback version.

## Issue Context
- Module name (`mach`) and distribution/project name (`mach-beamform`) can differ; `importlib.metadata.version()` expects the distribution name.

## Fix Focus Areas
- src/mach/__init__.py[11-14]
- pyproject.toml[5-8]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented Jun 2, 2026

Code review by qodo was updated up to the latest commit 928b943

@cmcneil cmcneil merged commit efb6c8f into main Jun 2, 2026
14 checks passed
@cmcneil cmcneil deleted the bump-0.1.2 branch June 2, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant