Skip to content

feat(workflow-executor): implement WorkflowPort adapter using forestadmin-client#1498

Merged
matthv merged 1 commit intofeat/prd-214-setup-workflow-executor-packagefrom
feature/prd-233-implementer-workflowport-calls-vers-le-serveur-forest-admin
Mar 18, 2026
Merged

feat(workflow-executor): implement WorkflowPort adapter using forestadmin-client#1498
matthv merged 1 commit intofeat/prd-214-setup-workflow-executor-packagefrom
feature/prd-233-implementer-workflowport-calls-vers-le-serveur-forest-admin

Conversation

@matthv
Copy link
Member

@matthv matthv commented Mar 18, 2026

Summary

  • Implements ForestServerWorkflowPort class that wraps ServerUtils.query from @forestadmin/forestadmin-client to communicate with the Forest Admin server via HTTP
  • Exports ServerUtils from forestadmin-client for reuse
  • Renames completeStepExecutionupdateStepExecution on the WorkflowPort interface
  • Route paths are placeholders (TODO in code) pending team alignment

Test plan

  • Unit tests with mocked ServerUtils.query for all 4 methods
  • Error propagation test
  • Lint + build pass

fixes PRD-233

🤖 Generated with Claude Code

Note

Implement ForestServerWorkflowPort adapter in workflow-executor using forestadmin-client

  • Adds ForestServerWorkflowPort, a new WorkflowPort implementation that communicates with the Forest server over HTTP using ServerUtils.query from @forestadmin/forestadmin-client.
  • Implements four methods: getPendingStepExecutions, updateStepExecution, getCollectionRef, and getMcpServerConfigs, each mapped to a specific /liana/v1/... route.
  • Renames completeStepExecution to updateStepExecution in the WorkflowPort interface.
  • Exposes ForestServerWorkflowPort as a public export from workflow-executor and adds ServerUtils to the forestadmin-client public API.
  • Behavioral Change: the WorkflowPort interface method rename is a breaking change for any existing implementations of completeStepExecution.

Macroscope summarized a0dd5a9.

…dmin-client

Adds ForestServerWorkflowPort that communicates with the Forest Admin
server via HTTP (ServerUtils.query) for workflow step orchestration.

Renames completeStepExecution to updateStepExecution.
Exports ServerUtils from forestadmin-client.

fixes PRD-233

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@linear
Copy link

linear bot commented Mar 18, 2026

@qltysh
Copy link

qltysh bot commented Mar 18, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (3)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
packages/forestadmin-client/src/index.ts100.0%
Coverage rating: A Coverage rating: A
packages/workflow-executor/src/index.ts100.0%
New file Coverage rating: A
.../workflow-executor/src/adapters/forest-server-workflow-port.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

export interface WorkflowPort {
getPendingStepExecutions(): Promise<PendingStepExecution[]>;
completeStepExecution(runId: string, stepHistory: StepHistory): Promise<void>;
updateStepExecution(runId: string, stepHistory: StepHistory): Promise<void>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@matthv matthv merged commit c25a953 into feat/prd-214-setup-workflow-executor-package Mar 18, 2026
30 checks passed
@matthv matthv deleted the feature/prd-233-implementer-workflowport-calls-vers-le-serveur-forest-admin branch March 18, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants