GameStateConverter: Add some extra information about cards#5
GameStateConverter: Add some extra information about cards#5cdaymand wants to merge 1 commit intoForgottenArbiter:masterfrom
Conversation
All these new information are needed to create a card description for slaythecli
ForgottenArbiter
left a comment
There was a problem hiding this comment.
Thanks for the pull request! I agree that these are some good things to have. Originally, the description, damage, block, and magic number were left out because it was possible to determine them from the rest of the game state, and I wanted to keep the state representation small. However, in the interest of not adding too much extra information to the game state (especially considering a large portion is often taken up by card objects, and it all needs to be transmitted over stdout), could we reduce the number of new fields? I was thinking:
- baseHeal, baseDraw, and baseDiscard are not used by the game, so they could be removed, along with heal, draw, and discard
- I don't believe base_magic_number and magic_number are both necessary, since I'm pretty sure they are always equal. I'll leave this one up to you, though.
- While you're at it, do you want to add ethereal? I've had that requested before, and for some reason I added exhaust, so ethereal is definitely in the same vein.
I do see why users might want both base_block and block though (same with damage). Also let me know if you think my concerns are completely unfounded.
|
At first when I did these changes, I was not completely sure about the information needed, now I am a bit more confident about the game source code and I agree for baseDraw and baseDiscard (not needed) In fact at the moment, after reading a post on reddit (regarding accessibility) I changed a bit my mind and I am completely doing the server part in java which handles all the game logic and send back a nice output. |
All these new information are needed to create a card description for slaythecli