-
Notifications
You must be signed in to change notification settings - Fork 8
Import and Export patterns #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: usbserial
Are you sure you want to change the base?
Conversation
|
Tested import and export round trip. Also tested that malformed json does not cause an error on import. Tested a file with > 39 values, < 39 values, and values > 255. Attempt to import an invalid json file will make no change to the matrix, and an error will be logged on the console. |
|
Added a Persistence checkbox. When this is checked, the display will never sleep, as the app will send the wake command in the background periodically before the sleep timer fires. |
|
Hi everyone, Mark and I are working together on a LED matrix monitoring project that uses the Framework LED Matrix module as a status/indicator display. This PR (#11) is a great fit for the hardware side of that workflow, since it defines a clear import/export format for patterns that can be sent directly to the device. To support the software side of the project (icon libraries, monitoring indicators, etc.), I’ve opened a follow-up PR #12: PR #12 is based on the current head of this PR and keeps all of the behavior here exactly as-is (39-byte hardware pattern format, UI, persist, wake loop). On top of that, it adds a separate “Export for Software” JSON export:
In practice, the workflow we’re aiming for is:
If you prefer to keep things focused on the hardware workflow, you can merge #11 on its own. If you’d like the software-oriented export alongside it, you can merge #12 instead as a superset of this work. I’m happy to adjust naming or wording in #12 based on your feedback. Thanks again for putting together the original import/export implementation—it's been very straightforward to build on. |
Added a button to export the current pattern on each matrix to a json file, and a button to import such a json file and apply it to either matrix.