Skip to content

chore(docker): native multi-arch via shared workflow#104

Open
gondoi wants to merge 4 commits into
masterfrom
feature/devops-1249-enable-multi-arch-build-containers-group-2
Open

chore(docker): native multi-arch via shared workflow#104
gondoi wants to merge 4 commits into
masterfrom
feature/devops-1249-enable-multi-arch-build-containers-group-2

Conversation

@gondoi
Copy link
Copy Markdown

@gondoi gondoi commented May 27, 2026

Summary

  • Migrate container builds to FuelLabs/github-actions/.github/workflows/docker-build-push.yml@master
  • Native multi-arch: linux/amd64 + linux/arm64 (ubuntu-latest / ubuntu-24.04-arm)

Test plan

  • CI passes on PR (amd64 + arm64 build jobs)
  • Image manifest lists both architectures after merge

Part of DEVOPS-1249 / Move to graviton.

Depends on github-actions master with checkout/LFS inputs (DEVOPS-1248).

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
forc-pub Ready Ready Preview, Comment May 27, 2026 8:08pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 27, 2026

PR Summary

Medium Risk
Changes how release images are built and published (new workflow, dual-arch), and how forc is bundled in the image; misconfiguration could break CI or arm64 runtime, but application code paths are untouched.

Overview
Container publishing no longer runs an inline Warp Buildx job in backend-ci.yml. It delegates to the shared FuelLabs/github-actions docker-build-push workflow with native linux/amd64 and linux/arm64 builds (ubuntu-latest / ubuntu-24.04-arm), registry login to ghcr.io, and the same image/tag metadata as before.

The test job only renames the binstall setup step and drops installing a pinned forc@0.65.0 via cargo binstall before cargo test.

In deployment/Dockerfile, the run image installs Sway forc binaries using TARGETARCH (amd64 / arm64) so each architecture pulls the matching forc-binaries-linux_* tarball instead of always using linux_amd64.

Reviewed by Cursor Bugbot for commit 949d70e. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 69e3bfb. Configure here.

Comment thread .github/workflows/backend-ci.yml
Use forc-binaries-linux_amd64 or linux_arm64 from Sway releases so
native arm64 image builds install runnable forc binaries.

Co-authored-by: Cursor <cursoragent@cursor.com>
No tests reference tests/fixtures/forc-0.65.0; integration tests install
forc via release tarballs at runtime. Source install fails on yanked core2.

Co-authored-by: Cursor <cursoragent@cursor.com>
Unit tests call install_binaries_at_path (cargo binstall + release
tarballs). Only the unused forc@0.65.0 source pre-install was removed.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant